Fix browser navigation not restoring the previous search. #24538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g back to a search qithout a query string, did not update the view.
…ange. For example when using the browser navigation.
Open
2 tasks
linuspahl
changed the title
linuspahl
commented
Dec 12, 2025
|
|
||
| if (newView !== view) { | ||
| return dispatch(updateView(newView, true)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This change is required to update the reflux store with the new view which contains the changes URL query params.
Contributor
Author
There was a problem hiding this comment.
Calling updateView also executes a new search and creates a new entry in the undo / redo stack.
linuspahl
commented
Dec 12, 2025
|
|
||
| const newSearch = view.search.toBuilder().newId().queries([newQuery]).build(); | ||
|
|
||
| const savedSearch = await createSearch(newSearch); |
Contributor
Author
There was a problem hiding this comment.
Since we are now calling updateView in bindSearchParamsFromQueryThunk we don't need to call it here anymore.
dennisoelkers
approved these changes
Jan 5, 2026
Member
dennisoelkers
left a comment
dennisoelkers
left a comment
There was a problem hiding this comment.
Looks good and works well!
garybot2
pushed a commit
that referenced
this pull request
Jan 5, 2026
* Properly notmalize empty query string. This fixes an error where going back to a search qithout a query string, did not update the view. * Properly update view and execute new search when URL query oparams change. For example when using the browser navigation. * Avoid executing search twice when using browser navigation. * Properly update browser history when creating a new search. * Ignore order of query params when comparing Uris. * Rever change that caused query input to be empty on replay search page. * Udpate tests * Extend tests * Improve tests * Adding changelog (cherry picked from commit a8bcfe7)
garybot2
pushed a commit
that referenced
this pull request
Jan 5, 2026
* Properly notmalize empty query string. This fixes an error where going back to a search qithout a query string, did not update the view. * Properly update view and execute new search when URL query oparams change. For example when using the browser navigation. * Avoid executing search twice when using browser navigation. * Properly update browser history when creating a new search. * Ignore order of query params when comparing Uris. * Rever change that caused query input to be empty on replay search page. * Udpate tests * Extend tests * Improve tests * Adding changelog (cherry picked from commit a8bcfe7)
garybot2
pushed a commit
that referenced
this pull request
Jan 5, 2026
* Properly notmalize empty query string. This fixes an error where going back to a search qithout a query string, did not update the view. * Properly update view and execute new search when URL query oparams change. For example when using the browser navigation. * Avoid executing search twice when using browser navigation. * Properly update browser history when creating a new search. * Ignore order of query params when comparing Uris. * Rever change that caused query input to be empty on replay search page. * Udpate tests * Extend tests * Improve tests * Adding changelog (cherry picked from commit a8bcfe7)
dennisoelkers
pushed a commit
that referenced
this pull request
Jan 6, 2026
…24636) * Properly notmalize empty query string. This fixes an error where going back to a search qithout a query string, did not update the view. * Properly update view and execute new search when URL query oparams change. For example when using the browser navigation. * Avoid executing search twice when using browser navigation. * Properly update browser history when creating a new search. * Ignore order of query params when comparing Uris. * Rever change that caused query input to be empty on replay search page. * Udpate tests * Extend tests * Improve tests * Adding changelog (cherry picked from commit a8bcfe7) Co-authored-by: Linus Pahl <[email protected]>
dennisoelkers
pushed a commit
that referenced
this pull request
Jan 6, 2026
…24637) * Properly notmalize empty query string. This fixes an error where going back to a search qithout a query string, did not update the view. * Properly update view and execute new search when URL query oparams change. For example when using the browser navigation. * Avoid executing search twice when using browser navigation. * Properly update browser history when creating a new search. * Ignore order of query params when comparing Uris. * Rever change that caused query input to be empty on replay search page. * Udpate tests * Extend tests * Improve tests * Adding changelog (cherry picked from commit a8bcfe7) Co-authored-by: Linus Pahl <[email protected]>
linuspahl
added a commit
that referenced
this pull request
Jan 6, 2026
…4638) * Fix browser navigation not restoring the previous search. (#24538) * Properly notmalize empty query string. This fixes an error where going back to a search qithout a query string, did not update the view. * Properly update view and execute new search when URL query oparams change. For example when using the browser navigation. * Avoid executing search twice when using browser navigation. * Properly update browser history when creating a new search. * Ignore order of query params when comparing Uris. * Rever change that caused query input to be empty on replay search page. * Udpate tests * Extend tests * Improve tests * Adding changelog (cherry picked from commit a8bcfe7) * Update import path --------- Co-authored-by: Linus Pahl <[email protected]> Co-authored-by: Linus Pahl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note, this PR needs to be backported.
Description
Motivation and Context
As described in #22105 and #18484 there are currently multiple issues with using the browser navigation.
These issues are mostly related to the following circumstances:
history.pushandhistory.replaceare being called when opening the search pagehistory.pushis called twice when using the browser navigationThis PR improves when
hisroty.pushandhistory.replaceare being called. Please note there is one issue #24539 left which needs to be addressed in a follow-up PR because it requires more fundamental changes.Fixes #22105
Fixes #18484