Return 404 instead of HTML for missing API methods. #24590
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janheise
reviewed
Jan 5, 2026
changelog/unreleased/pr-24590.toml
Outdated
| @@ -0,0 +1,4 @@ | |||
| type = "f" | |||
| message = "Return 404 instead of HTML for missing API methods." | |||
Contributor
There was a problem hiding this comment.
I would find "instead of HTML for a non existing API endpoint" more clear?
| @Path("{filename:.*}") | ||
| public Response getIndex(@Context ContainerRequest request, | ||
| @Context HttpHeaders headers) { | ||
| if (request.getAbsolutePath().getPath().startsWith("/api")) { |
Contributor
There was a problem hiding this comment.
I would add a comment on the purpose here, too. and not only rely on the changelog for explanation. Also, would it make sense to add /api as a constant to be re-used? (although it might be unlikely that we ever change that path)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR changes the default catch-all method which is supposed to return the frontend bootstrapping HTML for deep-links to check if the missing URL is an API endpoint and return a 404 instead.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: