Simplified plain json call to opensearch, refactored cluster adapter for os3 #24948
+523
−177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/nocl internal code cleanup
Description
This PR simplifies usages around direct request->json response (PlainJsonApi) in opensearch client, integrates the call in the OfficialOpenSearchClient, so we don't need yet another dependency.
This then enables a better testing approach, where we can use a serverless opensearch client where we can pre-register json responses to defined urls. The mocking happens on the transport layer and the original client is used for everything else (see screenshot below)
Motivation and Context
Code cleanup, removed extensive mocking, usages closer to actual code when testing. Tests are now not dependent on exact internal response structure of the client but use json responses returned from the actual opensearch server, increasing compatibility.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: