Fix pdk validate warnings

.gitignore

@@ -19,10 +19,17 @@
 /spec/fixtures/modules/*
 /tmp/
 /vendor/
+/.vendor/
 /convert_report.txt
 /update_report.txt
 .DS_Store
 .project
 .envrc
 /inventory.yaml
 /spec/fixtures/litmus_inventory.yaml
+.resource_types
+.modules
+.task_cache.json
+.plan_cache.json
+.rerun.json
+bolt-debug.log

.pdkignore

@@ -19,16 +19,24 @@
 /spec/fixtures/modules/*
 /tmp/
 /vendor/
+/.vendor/
 /convert_report.txt
 /update_report.txt
 .DS_Store
 .project
 .envrc
 /inventory.yaml
 /spec/fixtures/litmus_inventory.yaml
+.resource_types
+.modules
+.task_cache.json
+.plan_cache.json
+.rerun.json
+bolt-debug.log
 /.fixtures.yml
 /Gemfile
 /.gitattributes
+/.github/
 /.gitignore
 /.pdkignore
 /.puppet-lint.rc
@@ -41,6 +49,3 @@
 /.vscode/
 /.sync.yml
 /.devcontainer/
-/Rakefile.release
-/Vagrantfile
-/tests

.puppet-lint.rc

@@ -1 +1,9 @@
+--fail-on-warnings
 --relative
+--no-80chars-check
+--no-140chars-check
+--no-class_inherits_from_params_class-check
+--no-autoloader_layout-check
+--no-documentation-check
+--no-single_quote_string_with_variables-check
+--ignore-paths=.vendor/**/*.pp,.bundle/**/*.pp,pkg/**/*.pp,spec/**/*.pp,tests/**/*.pp,types/**/*.pp,vendor/**/*.pp

.rubocop.yml

@@ -3,6 +3,7 @@ require:
 - rubocop-performance
 - rubocop-rspec
 AllCops:
+  NewCops: enable
   DisplayCopNames: true
   TargetRubyVersion: '2.6'
   Include:
@@ -527,6 +528,8 @@ Lint/DuplicateBranch:
   Enabled: false
 Lint/DuplicateMagicComment:
   Enabled: false
+Lint/DuplicateMatchPattern:
+  Enabled: false
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: false
 Lint/EmptyBlock:
@@ -643,6 +646,8 @@ Style/ComparableClamp:
   Enabled: false
 Style/ConcatArrayLiterals:
   Enabled: false
+Style/DataInheritance:
+  Enabled: false
 Style/DirEmpty:
   Enabled: false
 Style/DocumentDynamicEvalDefinition:
@@ -711,6 +716,8 @@ Style/RedundantHeredocDelimiterQuotes:
   Enabled: false
 Style/RedundantInitialize:
   Enabled: false
+Style/RedundantLineContinuation:
+  Enabled: false
 Style/RedundantSelfAssignmentBranch:
   Enabled: false
 Style/RedundantStringEscape:

Gemfile

@@ -20,25 +20,31 @@ group :development do
   gem "json", '= 2.6.1',                         require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
   gem "json", '= 2.6.3',                         require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
   gem "racc", '~> 1.4.0',                        require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
+  gem "deep_merge", '~> 1.2.2',                  require: false
   gem "voxpupuli-puppet-lint-plugins", '~> 5.0', require: false
-  gem "facterdb", '~> 1.18',                     require: false
-  gem "metadata-json-lint", '~> 3.0',            require: false
-  gem "puppetlabs_spec_helper", '~> 6.0',        require: false
-  gem "rspec-puppet-facts", '~> 2.0',            require: false
-  gem "codecov", '~> 0.2',                       require: false
+  gem "facterdb", '~> 2.1',                      require: false
+  gem "metadata-json-lint", '~> 4.0',            require: false
+  gem "rspec-puppet-facts", '~> 4.0',            require: false
   gem "dependency_checker", '~> 1.0.0',          require: false
   gem "parallel_tests", '= 3.12.1',              require: false
   gem "pry", '~> 0.10',                          require: false
-  gem "simplecov-console", '~> 0.5',             require: false
+  gem "simplecov-console", '~> 0.9',             require: false
   gem "puppet-debugger", '~> 1.0',               require: false
-  gem "rubocop", '= 1.48.1',                     require: false
+  gem "rubocop", '~> 1.50.0',                    require: false
   gem "rubocop-performance", '= 1.16.0',         require: false
   gem "rubocop-rspec", '= 2.19.0',               require: false
   gem "rb-readline", '= 0.5.5',                  require: false, platforms: [:mswin, :mingw, :x64_mingw]
+  gem "rexml", '>= 3.0.0', '< 3.2.7',            require: false
+end
+group :development, :release_prep do
+  gem "puppet-strings", '~> 4.0',         require: false
+  gem "puppetlabs_spec_helper", '~> 8.0', require: false
+  gem "puppet-blacksmith", '~> 7.0',      require: false
 end
 group :system_tests do
-  gem "puppet_litmus", '~> 1.0', require: false, platforms: [:ruby, :x64_mingw]
-  gem "serverspec", '~> 2.41',   require: false
+  gem "puppet_litmus", '~> 1.0',   require: false, platforms: [:ruby, :x64_mingw]
+  gem "CFPropertyList", '< 3.0.7', require: false, platforms: [:mswin, :mingw, :x64_mingw]
+  gem "serverspec", '~> 2.41',     require: false
 end
 
 puppet_version = ENV['PUPPET_GEM_VERSION']

Gemfile.lock

@@ -11,7 +11,7 @@ GEM
     ast (2.4.2)
     awesome_print (1.9.2)
     aws-eventstream (1.3.0)
-    aws-partitions (1.1034.0)
+    aws-partitions (1.1033.0)
     aws-sdk-core (3.214.1)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.992.0)
@@ -49,8 +49,6 @@ GEM
       winrm (~> 2.0)
       winrm-fs (~> 1.3)
     builder (3.3.0)
-    codecov (0.6.0)
-      simplecov (>= 0.15, < 0.22)
     coderay (1.1.3)
     colored2 (3.1.2)
     concurrent-ruby (1.3.4)
@@ -73,7 +71,7 @@ GEM
     facter (4.10.0)
       hocon (~> 1.3)
       thor (>= 1.0.1, < 1.3)
-    facterdb (1.27.0)
+    facterdb (2.1.0)
       facter (< 5.0.0)
       jgrep (~> 1.5, >= 1.5.4)
     faraday (2.12.2)
@@ -89,8 +87,9 @@ GEM
       net-http-persistent (>= 4.0.4, < 5)
     fast_gettext (2.4.0)
       prime
-    ffi (1.17.1)
+    ffi (1.17.1-x86_64-linux-gnu)
     forwardable (1.3.3)
+    getoptlong (0.2.1)
     gettext (3.5.0)
       erubi
       locale (>= 2.0.5)
@@ -106,42 +105,43 @@ GEM
     gyoku (1.4.0)
       builder (>= 2.1.2)
       rexml (~> 3.0)
-    hiera (3.12.0)
     hiera-eyaml (3.4.0)
       highline
       optimist
     highline (3.1.2)
       reline
     hocon (1.4.0)
     http-accept (1.7.0)
-    http-cookie (1.0.8)
+    http-cookie (1.0.7)
       domain_name (~> 0.5)
     httpclient (2.8.3)
     io-console (0.8.0)
     jgrep (1.5.4)
     jmespath (1.6.2)
-    json (2.5.1)
-    json-schema (4.3.1)
-      addressable (>= 2.8)
+    json (2.6.3)
+    json-schema (5.1.0)
+      addressable (~> 2.8)
     jwt (2.10.1)
       base64
     little-plugger (1.1.4)
     locale (2.1.4)
     log4r (1.1.10)
-    logger (1.6.5)
+    logger (1.6.4)
     logging (2.4.0)
       little-plugger (~> 1.1)
       multi_json (~> 1.14)
-    metadata-json-lint (3.0.3)
-      json-schema (>= 2.8, < 5.0)
+    metadata-json-lint (4.1.0)
+      json-schema (>= 2.8, < 6.0)
+      semantic_puppet (~> 1.0)
       spdx-licenses (~> 1.0)
     method_source (1.1.0)
     mime-types (3.6.0)
       logger
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2025.0107)
+    mime-types-data (3.2024.1105)
     minitar (0.12.1)
-    mocha (1.16.1)
+    mocha (2.6.1)
+      ruby2_keywords (>= 0.0.5)
     molinillo (0.8.0)
     multi_json (1.15.0)
     net-http (0.6.0)
@@ -169,7 +169,7 @@ GEM
     parser (3.3.6.0)
       ast (~> 2.4.1)
       racc
-    pathspec (1.1.3)
+    pathspec (2.1.0)
     pluginator (1.5.0)
     prime (0.1.3)
       forwardable
@@ -178,19 +178,19 @@ GEM
       coderay (~> 1.1)
       method_source (~> 1.0)
     public_suffix (6.0.1)
-    puppet (7.34.0)
+    puppet (8.10.0)
       concurrent-ruby (~> 1.0)
       deep_merge (~> 1.0)
-      facter (> 2.0.1, < 5)
-      fast_gettext (>= 1.1, < 3)
-      hiera (>= 3.2.1, < 4)
+      facter (>= 4.3.0, < 5)
+      fast_gettext (>= 2.1, < 4)
+      getoptlong (~> 0.2.0)
       locale (~> 2.1)
-      multi_json (~> 1.10)
+      multi_json (~> 1.13)
       puppet-resource_api (~> 1.5)
       scanf (~> 1.0)
       semantic_puppet (~> 1.0)
-    puppet-blacksmith (8.0.0)
-      puppet-modulebuilder (~> 2.0, >= 2.0.2)
+    puppet-blacksmith (7.1.0)
+      puppet-modulebuilder (~> 1.0)
       rest-client (~> 2.0)
     puppet-debugger (1.4.0)
       awesome_print (~> 1.7)
@@ -236,17 +236,17 @@ GEM
       puppet-lint (>= 3, < 5)
     puppet-lint-version_comparison-check (2.0.0)
       puppet-lint (>= 3, < 5)
-    puppet-modulebuilder (2.0.2)
+    puppet-modulebuilder (1.1.0)
       minitar (~> 0.9)
       pathspec (>= 0.2.1, < 3.0.0)
     puppet-resource_api (1.9.0)
       hocon (>= 1.0)
     puppet-strings (4.1.3)
       rgen (~> 0.9)
       yard (~> 0.9, < 0.9.37)
-    puppet-syntax (3.3.0)
-      puppet (>= 5)
-      rake
+    puppet-syntax (4.1.1)
+      puppet (>= 7, < 9)
+      rake (~> 13.1)
     puppet_forge (5.0.4)
       faraday (~> 2.0)
       faraday-follow_redirects (~> 0.3.0)
@@ -263,13 +263,13 @@ GEM
     puppetfile-resolver (0.6.3)
       molinillo (~> 0.6)
       semantic_puppet (~> 1.0)
-    puppetlabs_spec_helper (6.0.3)
-      mocha (~> 1.0)
-      pathspec (>= 0.2, < 2.0.0)
+    puppetlabs_spec_helper (8.0.0)
+      mocha (>= 1.0, < 3)
+      pathspec (>= 0.2, < 3)
       puppet-lint (~> 4.0)
-      puppet-syntax (~> 3.0)
+      puppet-syntax (~> 4.1, >= 4.1.1)
       rspec-github (~> 2.0)
-      rspec-puppet (~> 4.0)
+      rspec-puppet (~> 5.0)
     r10k (4.1.0)
       colored2 (= 3.1.2)
       cri (>= 2.15.10)
@@ -292,7 +292,7 @@ GEM
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
     retryable (3.0.5)
-    rexml (3.4.0)
+    rexml (3.2.6)
     rgen (0.9.1)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
@@ -311,21 +311,22 @@ GEM
     rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-puppet (4.0.2)
+    rspec-puppet (5.0.0)
       rspec (~> 3.0)
-    rspec-puppet-facts (2.0.5)
-      facter
-      facterdb (>= 0.5.0)
-      puppet
+    rspec-puppet-facts (4.0.0)
+      deep_merge (~> 1.2)
+      facter (< 5)
+      facterdb (~> 2.1)
+      puppet (>= 7, < 9)
     rspec-support (3.13.2)
-    rubocop (1.48.1)
+    rubocop (1.50.2)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.2.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.26.0, < 2.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.37.0)
@@ -339,6 +340,7 @@ GEM
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
     ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
     ruby_smb (1.1.0)
       bindata
       rubyntlm
@@ -354,7 +356,7 @@ GEM
       rspec-its
       specinfra (~> 2.72)
     sfl (2.3)
-    simplecov (0.21.2)
+    simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
@@ -433,25 +435,28 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
-  codecov (~> 0.2)
+  CFPropertyList (< 3.0.7)
+  deep_merge (~> 1.2.2)
   dependency_checker (~> 1.0.0)
-  facterdb (~> 1.18)
-  json (= 2.5.1)
-  metadata-json-lint (~> 3.0)
+  facterdb (~> 2.1)
+  json (= 2.6.3)
+  metadata-json-lint (~> 4.0)
   parallel_tests (= 3.12.1)
   pry (~> 0.10)
-  puppet
-  puppet-blacksmith
+  puppet (= 8.10.0)
+  puppet-blacksmith (~> 7.0)
   puppet-debugger (~> 1.0)
+  puppet-strings (~> 4.0)
   puppet_litmus (~> 1.0)
-  puppetlabs_spec_helper (~> 6.0)
+  puppetlabs_spec_helper (~> 8.0)
   rb-readline (= 0.5.5)
-  rspec-puppet-facts (~> 2.0)
-  rubocop (= 1.48.1)
+  rexml (>= 3.0.0, < 3.2.7)
+  rspec-puppet-facts (~> 4.0)
+  rubocop (~> 1.50.0)
   rubocop-performance (= 1.16.0)
   rubocop-rspec (= 2.19.0)
   serverspec (~> 2.41)
-  simplecov-console (~> 0.5)
+  simplecov-console (~> 0.9)
   voxpupuli-puppet-lint-plugins (~> 5.0)
 
 BUNDLED WITH