Removing allinone class #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in issue Graylog2#76, I am removing the allinone class and the associated unit test.
bernd
reviewed
Jan 30, 2025
Member
bernd
left a comment
bernd
left a comment
There was a problem hiding this comment.
Thank you! Can you also remove the test code in the tests/ folder and the Vagrantfilefile? I was using the code for manual testing with Vagrant. Since we now have the litmus tests, we don't need that anymore.
Member
|
Oh, and please remove the allinone documentation from the README.md file. Thanks! |
Contributor
Author
|
Absolutely! I'm sorry I didn't catch these things initially, especially updating the documentation. |
This commit removes Vagrant-based tests. It also updates the README file to remove references to the allinone class. It also adds information about how to test the code without the Vagrant-based tests.
Contributor
Author
|
I removed the Vagrant-based tests and the allinone documentation from the readme. I also added some info in the readme about how to test using pdk and litmus. I also added details for using pdk in the contributing file. I hope this is acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #76, I am removing the allinone class and the associated unit test.
Notes for Reviewers