refactor: Phase 2 - ReadingType ESPI 4.0 schema compliance (field order) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordered ReadingType entity, DTO, and migration fields to match ESPI 4.0 XSD element sequence (espi.xsd:382-481). Changes: - ReadingTypeEntity: Reordered fields 13-18 to match XSD sequence: timeAttribute, tou, uom, cpp, interharmonic, measuringPeriod, argument - ReadingTypeDto: Updated @XmlType propOrder and record component order to match XSD (removed description from propOrder as it belongs to IdentifiedObject/Atom) - V1__Create_Base_Tables.sql: Reordered reading_types table columns to match XSD sequence - ReadingTypeMapper: No changes required (MapStruct maps by field name, not order) All tests passing (550 tests). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reordered ReadingType entity, DTO, and migration fields to match ESPI 4.0 XSD element sequence (espi.xsd:382-481).
Changes
timeAttribute → tou → uom → cpp → interharmonic → measuringPeriod → argument@XmlType propOrderand record component order to match XSDdescriptionfrom propOrder (belongs to IdentifiedObject/Atom, not ReadingType)reading_typestable columns to match XSD sequenceTest Results
✅ All 550 tests passing
Schema Compliance
This change ensures ReadingType field order matches the ESPI 4.0 XSD specification exactly, which is critical for:
🤖 Generated with Claude Code