[WIP] Add geocoding using NYC GeoSearch API with autosuggest #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clhenrick
changed the title
clhenrick
changed the title
clhenrick
changed the title
clhenrick
commented
May 21, 2018
| return ( | ||
| <div className="Search ui"> | ||
| <Autosuggest | ||
| onSuggestionsFetchRequested={throttle(onSuggestionsFetchRequested, THROTTLE_WAIT_MS)} |
There was a problem hiding this comment.
should probably use debounce instead of throttle here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress for #92
Still needs:
for selected search result to show up on map & map to zoom to result
clean up unused code relating to redux
state.geocoding(or changestate.searchtostate.geocodingif that's more clear,state.geocodingwas left over when I was trying to implement intersect by address for Improve Filter by Intersection UX #76)to remove old css and components relating to SearchForm
some more CSS adjustments
enable filter by radius of geocode result (?)