Skip to content

PR 110 redux#121

Merged
andreww merged 3 commits intomainfrom
aturner_pr
Feb 14, 2025
Merged

PR 110 redux#121
andreww merged 3 commits intomainfrom
aturner_pr

Conversation

@andreww
Copy link
Copy Markdown
Collaborator

@andreww andreww commented Dec 6, 2024

@aturner's PR #110 with merge conflict resolved and a test added

As previously: Adds the option to set CATS_CONFIG_FILE environment variable to specify config file location. Config file location precedence becomes:

  1. Command line option
  2. Location specified in CATS_CONFIG_FILE
  3. ./config.yaml

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (99737e8) to head (68e45ee).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cats/configure.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   88.48%   87.20%   -1.29%     
==========================================
  Files          14       14              
  Lines         573      586      +13     
==========================================
+ Hits          507      511       +4     
- Misses         66       75       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreww
Copy link
Copy Markdown
Collaborator Author

andreww commented Dec 6, 2024

All looked okay in PR #110 - could somebody review and merge?

Copy link
Copy Markdown
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Doesn't look like CATS actually loads config.yaml (only config.yml) though, so we should change the docs to match

We only look for config.yml
@andreww andreww merged commit 81d44d0 into main Feb 14, 2025
9 of 11 checks passed
@andreww andreww deleted the aturner_pr branch February 14, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants