122 sbatch

[abhidg]

• ci: update pre-commit hooks
• feat: add sbatch scheduler support, fixes scheduler: add sbatch #122

[codecov]

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.46%. Comparing base (d1678ae) to head (96c4aef).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
cats/__init__.py	57.14%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   87.41%   87.46%   +0.04%     
==========================================
  Files          13       13              
  Lines         604      630      +26     
==========================================
+ Hits          528      551      +23     
- Misses         76       79       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[andreww]

This all looks okay to me. Has it been tested in reality on a system running slurm?

[sadielbartholomew]

@abhidg do you need a second review or is one sufficient?

[abhidg]

@sadielbartholomew could you check if this PR works in a cluster? I don't have an account on our supercomputer ATM.

[sadielbartholomew]

could you check if this PR works in a cluster? I don't have an account on our supercomputer ATM.

Sure, as long as you don't mind waiting a couple of days - I have some urgent work to sort for tomorrow and it will take a bit more time to review on JASMIN or ARCHER2. Will aim to submit a cluster-based review by the end of the week.

[colinsauze]

I've just tested this on our cluster at NOC and it is happily submitting jobs to the slurm queue.
To match the behaviour of invoking sbatch directly (and how Cats works with At) it would be very helpful to be able to display the job number on screen after submission.

[colinsauze]

Also tested on JASMIN (newer version of slurm, 24.11.0 instead of 23.02.6) and it is working there.

[abhidg]

Thanks @colinsauze! I have created an issue to display the job number on submission.

[sadielbartholomew]

Sorry @abhidg this clearly fell off my radar, but thanks @colinsauze for testing on JASMIN! Brilliant to hear that it is working with SLURM.