ci: publish to PyPi on new release, fixes #141#147
Conversation
abhidg
requested review from
andreww,
colinsauze,
sadielbartholomew and
tonymugen
There was a problem hiding this comment.
By eyeball, looks to configure the dedicated publish external workflow correctly for our context and the YAML is all valid so nothing strikes me as amiss, however I don't know a good way to test it explicitly without changing it around too much to use TestPyPI - don't want to accidentally create a new official release from a test/fork branch!
Happy to approve regardless but for validation/reassurance it would be good to know it has been tested - have you checked this via publishing to TestPyPI or otherwise?
andreww
left a comment
andreww
left a comment
There was a problem hiding this comment.
I think essentially we just need to try in and see. Worst that can happen? An extra version on PyPi that doesn't work and we fix it by hand. The process should probably be documented (but maybe just open an issue with text saying how to create a PyPi release.
I'm guessing there are also settings on the PyPi side that you've had to change. Are these tied to your account there @abhidg? We probably need to avoid the situation where we have single person points of failure (I guess I need to deal with the same thing on ReadTheDocs now).
| run: | | ||
| python -m build | ||
| - name: Publish package distributions to PyPI | ||
| uses: pypa/gh-action-pypi-publish@release/v1 |
There was a problem hiding this comment.
Should we pin to a particular commit id for this action (rather than a branch)? In principle, it is possible for the branch to change under us so what happens when we create a new release could change. At least, that's what it suggests in the documentation
3 participants
No description provided.