Add test case for issue 127#161
Merged
andreww merged 2 commits intoGreenScheduler:mainfrom Sep 12, 2025
Merged
Conversation
As far as I can tell, we now give an optimal CI of ~19 g CO2e/kWh not 22.07 because of fixes that went in before version 1.1. The optimal start time does not change (and the optimal start time is to start "now").
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 82.72% 83.31% +0.58%
==========================================
Files 14 15 +1
Lines 712 737 +25
==========================================
+ Hits 589 614 +25
Misses 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Another bug we've fixed. The test here is a dull dataset that just decreases with time. The 30 min job sits in the last time period and gives a value half way between the last two data points
Collaborator
Author
|
Added test for issue 32 to this PR. |
abhidg
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, we now give an optimal CI of ~19 g CO2e/kWh not 22.07 because of fixes that went in before version 1.1. The optimal start time does not change (and the optimal start time is to start "now").