Add gallery view and verify editing to Captures#298
Open
gwynndp wants to merge 9 commits intoGreenstand:masterfrom
Open
Add gallery view and verify editing to Captures#298gwynndp wants to merge 9 commits intoGreenstand:masterfrom
gwynndp wants to merge 9 commits intoGreenstand:masterfrom
Conversation
Collaborator
Author
|
@TANguyen1893 Thanks for your feedback! I've made those changes. |
7959d48 to
b57a388
Compare
b57a388 to
fbcb766
Compare
TANguyen1893
approved these changes
Jan 24, 2022
Collaborator
TANguyen1893
left a comment
There was a problem hiding this comment.
Nice work! LGTM. Let's maybe have another person with more domain knowledge give an approval as well.
Collaborator
|
I don't think we're ready for the edit function yet, I'm expecting this to go through some design loops before we land on how we want it to work. For now, I think the gallery/list toggle would suffice. With that in mind, we don't need the side bar or the selection function. |
fbcb766 to
338c291
Compare
…add invalidateCaptureCount
ec792f8 to
c4a444f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrate Verify features into CapturesView in preparation for CVAT
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfills these requirements
Bugs found
The filters for organization, species, and tags seem to be broken, but the bug was already on the master branch.