Org Screen Tested #1053
Open
Org Screen Tested #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elforama
requested changes
Jan 11, 2023
Contributor
Elforama
left a comment
Elforama
left a comment
There was a problem hiding this comment.
Thanks for making this test. Once you address the comments I can merge this.
app/src/androidTest/java/org/greenstand/android/TreeTracker/orgpicker/FakeOrgITem.kt
Outdated
Show resolved
Hide resolved
Comment on lines
26
to
32
| Org( | ||
| FakeOrgITem.orgitem.id, | ||
| FakeOrgITem.orgitem.name, | ||
| FakeOrgITem.orgitem.walletId, | ||
| FakeOrgITem.orgitem.logoPath, | ||
| FakeOrgITem.orgitem.captureSetupFlow, | ||
| FakeOrgITem.orgitem.captureFlow |
Contributor
There was a problem hiding this comment.
You can just pass in the fake item instead of making a new one.
app/src/main/java/org/greenstand/android/TreeTracker/orgpicker/OrgPickerScreen.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,45 @@ | |||
| package org.greenstand.android.TreeTracker.orgpicker | |||
|
|
|||
| import androidx.compose.ui.test.* | |||
Contributor
There was a problem hiding this comment.
When trying to run this test locally I couldn't get it working. Were you able to run this test?
app/src/androidTest/java/org/greenstand/android/TreeTracker/orgpicker/OrgPickerScreenKtTest.kt
Show resolved
Hide resolved
precious3173
commented
Jan 15, 2023
Author
precious3173
left a comment
precious3173
left a comment
There was a problem hiding this comment.
The select_organisation string resource could not be resolve
Contributor
|
@precious3173 Were you able to fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.