Conversation
This change updates the CI workflow to automatically run integration tests when a pull request is marked as "ready for review", including PRs from forks it includes headless end-to-end web tests and all workspace unit tests Switched from lint:fix to lint:check to avoid automatically modifying code during CI runs
|
@Koda-Pig I read you code, correct me if I’m wrong: |
|
@dadiorchen Would it make sense for @Koda-Pig to combine the e2e-web job with this CI file instead? https://github.com/Greenstand/treetracker-wallet-app/blob/main/.github/workflows/github-ci.yml |
|
@pierrelstan I was told that I need to insert the DB url to get the tests to work on local, but I must not push that change. |
|
Yes, let me clarify days. We need a database URL to run the project locally you put it into your environment wearable somewhere, but you cannot push that to cloud so to set up the environment variable in the GITH UB action you need to set up a depository environment, variable in the settings |
|
@Koda-Pig any updates on this PR ? |
|
@pierrelstan I have some questions about this I was discussing on slack, here is the link to the thread: https://greenstand.slack.com/archives/C05TVUSEQQ0/p1756849804041739?thread_ts=1755160534.279099&cid=C05TVUSEQQ0 I was told I need to insert the database URL somewhere for the tests to work, but I must not commit that change. I've been trying to get answers about this for a while now. |
|
@Koda-Pig if you can run it locally then when you run it in CI/CT you you need to set up the GitHub repository secret |
|
@pierrelstan I still can't get this to work on local. You can assign this to someone else, I'm not going to work on this anymore. |
Description
Updates CI workflow to trigger integration tests on PR ready_for_review event. Includes headless E2E web tests and all workspace unit tests. Changed from lint:fix to lint:check to prevent code mutation during CI.
The new check that runs has some failed tests, but they are the exact same failed tests with the same error messages as when running the tests locally.
Fixes: #504
Changes Made
.github/workflowsType of Change
functionality to not work as expected)
Screenshots
N/A
How Has This Been Tested?
Checklist:
Additional Comments
N/A