add confirmation dialog for discarding new wallet form changes#519
Closed
fengyunfengyun1 wants to merge 3 commits intoGreenstand:mainfrom
Closed
add confirmation dialog for discarding new wallet form changes#519fengyunfengyun1 wants to merge 3 commits intoGreenstand:mainfrom
fengyunfengyun1 wants to merge 3 commits intoGreenstand:mainfrom
Conversation
fengyunfengyun1
force-pushed
the
create_new_wallet_confirmation_form
branch
from
12fbf8d to
862d465
Compare
pierrelstan
requested changes
Sep 6, 2025
Collaborator
There was a problem hiding this comment.
Add Cypress component tests to cover:
-
Drawer open/close behavior.
-
"Create Wallet" button enable/disable logic.
-
Duplicate name validation.
-
Confirmation dialog behavior.
Note: The confirmation dialog currently does not open as expected — this needs to be fixed.
| </Box> | ||
| </Drawer> | ||
| <> | ||
| <Drawer |
Collaborator
There was a problem hiding this comment.
Drawer should be tied with a aria-labelledby
| onClose(); | ||
| }; | ||
|
|
||
| const requestClose = useCallback(() => { |
Collaborator
There was a problem hiding this comment.
The requestClose logic works well, but renaming it to handleCloseRequest would align better with common handler naming conventions.
Contributor
Author
|
all changes were in #564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add confirmation dialog for discarding new wallet form changes
Fixes: #364
or
Resolves: # (issue number)
Changes Made
Changes in
appsfolder (specify the app and briefly describe thechanges):
WebNativeChanges in
packagesfolder (specify the package and briefly describethe changes):
CoreType of Change
functionality to not work as expected)
Screenshots
How Has This Been Tested?
Checklist:
Additional Comments
(Optional) Add any additional comments or notes for reviewers here.