Closed
Conversation
aneepal55
force-pushed
the
add_wallet_list
branch
from
e453189 to
5f3756b
Compare
aneepal55
force-pushed
the
add_wallet_list
branch
from
5f3756b to
b79f862
Compare
pierrelstan
requested changes
Sep 16, 2025
Comment on lines
20
to
30
|
|
||
| <View style={styles.container}> | ||
| <View style={styles.createWalletSection}> | ||
| <TouchableOpacity style={styles.createWalletButton} onPress={handleCreateWallet}> | ||
| <Text style={styles.plusIcon}>+</Text> | ||
| <Text style={styles.createWalletText}>CREATE WALLET</Text> | ||
| </TouchableOpacity> | ||
| <TouchableOpacity style={styles.infoIcon} onPress={handleInfoPress}> | ||
| <Text style={styles.infoIconText}>i</Text> | ||
| </TouchableOpacity> | ||
| </View> |
Collaborator
There was a problem hiding this comment.
@aneepal55 Please remove this part from the PR.
Contributor
Author
|
@pierrelstan hello, i made the proposed changes please take a look at it. |
pierrelstan
reviewed
Oct 2, 2025
| <Text style={styles.walletsTitle}>Your wallets</Text> | ||
|
|
||
| <View style={styles.walletsContainer}> | ||
| <TouchableOpacity style={styles.walletItem}> |
Collaborator
There was a problem hiding this comment.
Replace TouchableOpacity with Link for navigation — it’s cleaner and aligns better with Expo Router’s declarative routing.
pierrelstan
requested changes
Oct 2, 2025
Comment on lines
25
to
44
| <View style={styles.walletInfo}> | ||
| <Text style={styles.walletName}>Wallet 2</Text> | ||
| <Text style={styles.walletDate}>May 22, 2024</Text> | ||
| </View> | ||
| <View style={styles.walletRight}> | ||
| <Text style={styles.walletAmount}>1000</Text> | ||
| <Text style={styles.chevron}>›</Text> | ||
| </View> | ||
| </TouchableOpacity> | ||
|
|
||
| <View style={styles.separator} /> | ||
|
|
||
| <TouchableOpacity style={styles.walletItem}> | ||
| <View style={styles.walletInfo}> | ||
| <Text style={styles.walletName}>Wallet 1</Text> | ||
| <Text style={styles.walletDate}>May 16, 2024</Text> | ||
| </View> | ||
| <View style={styles.walletRight}> | ||
| <Text style={styles.walletAmount}>3455</Text> | ||
| <Text style={styles.chevron}>›</Text> |
Collaborator
There was a problem hiding this comment.
Abstract the wallet list to be data-driven rather than static.
Contributor
Author
|
@pierrelstan i made the requested changes, please take a look at it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a clear and concise description of the changes made, including
the purpose and context.
Fixes: # (issue number)
or
Resolves: #362
Changes Made
Changes in
appsfolder (specify the app and briefly describe thechanges):
WebNativeChanges in
packagesfolder (specify the package and briefly describethe changes):
CoreType of Change
functionality to not work as expected)
Screenshots
How Has This Been Tested?
Checklist:
Additional Comments
(Optional) Add any additional comments or notes for reviewers here.