feat: implement create wallet button with figma replication and icons#549
feat: implement create wallet button with figma replication and icons#549Praneetha15 wants to merge 2 commits intoGreenstand:mainfrom
Conversation
There was a problem hiding this comment.
Suggestions & Improvements
- Simplify icons by using the Expo Vector Icons package
- Add accessibility role and label to TouchableOpacity for better screen reader support
- Make backgroundColor DRY (it’s currently repeated in multiple styles)
- Refer to the contributing docs for commit message guidelines: https://github.com/Greenstand/treetracker-wallet-app/blob/main/CONTRIBUTING.md
|
@pierrelstan I made the requested changes could you please check it and let me know if any more changes are required. |
|
@Praneetha15 Could you explain why the tsconfig.json file is included in this PR? |
|
@pierrelstan I reverted apps/native/tsconfig.json to exactly match upstream main so this PR no longer includes any tsconfig changes. I’ve also merged the latest changes from upstream/main into this branch to stay up to date. The PR now only contains the intended wallet UI updates. |
pierrelstan
left a comment
There was a problem hiding this comment.
Could you squash the last three commits into one using git rebase -i HEAD~(any number) and then rebase onto the main branch using git rebase origin/main? This ensures the code is up-to-date with the main branch and has a clean, linear history.
…\n\n- Replace custom SVGs with Expo Vector Icons\n- Add accessibilityRole and accessibilityLabel to buttons\n- Use Colors.background instead of hardcoded values\n- Keep PR focused and up to date with main
f7e07db to
4b820a0
Compare
|
I noticed some upstream changes (workflow, .gitignore, bdd files) appeared in this branch after syncing with main. I can remove those and make the PR only contains my "native wallet" updates (apps/native/app/(tabs)/wallet/index.tsx and apps/native/constants/Colors.ts). Would you prefer I do that, or is the current diff acceptable? |
|
@Praneetha15 The PR should focus only on the Wallet screen changes. Please exclude any unrelated changes to keep it clean. |
Description
Please provide a clear and concise description of the changes made, including
the purpose and context.
Fixes: # (issue number)
or
Resolves: # (issue number)
Changes Made
Changes in
appsfolder (specify the app and briefly describe thechanges):
WebNativeChanges in
packagesfolder (specify the package and briefly describethe changes):
CoreType of Change
functionality to not work as expected)
Screenshots
How Has This Been Tested?
Checklist:
Additional Comments
(Optional) Add any additional comments or notes for reviewers here.