Skip to content

Comments

fix(bdd): create new wallet#637

Closed
nachikamod wants to merge 2 commits intomainfrom
fix/nk-bdd-create-wallet
Closed

fix(bdd): create new wallet#637
nachikamod wants to merge 2 commits intomainfrom
fix/nk-bdd-create-wallet

Conversation

@nachikamod
Copy link
Collaborator

Description

This commit fixes and implements create wallet function and bdd.

Fixes: #631


Changes Made

  • Changes in apps folder (specify the app and briefly describe the
    changes):

    • Web: Adds data-test for each wallet name for each wallet row for easy access in tests and updates .env.example for correct environment variables needed for the web.
    • bdd: Fixes create wallet bdd and updates step definitions for more robust wallet creation confirmation using name
  • Changes in packages folder (specify the package and briefly describe
    the changes):

    • wallet: Removes unused environment variable WALLET_API_KEY as its not needed for the api

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • 📝 Documentation update (changes)

How Has This Been Tested?

  • bdd e2e tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nachikamod nachikamod self-assigned this Dec 12, 2025
Copy link
Collaborator

@dadiorchen dadiorchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

"@wdio/local-runner": "^9.18.4",
"@wdio/spec-reporter": "^9.18.0",
"chromedriver": "^141.0.0",
"chromedriver": "^143.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nachikamod why you need to upgrade this?

@@ -12,7 +12,6 @@ async function createWallet(walletData: Wallet, token: string) {
},
{
headers: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nachikamod am I correct, because we are using Bearer token of user, so we don’t need the wallet api key anymore, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@nachikamod
Copy link
Collaborator Author

Closing this PR and creating a new one

@nachikamod nachikamod closed this Dec 13, 2025
@nachikamod nachikamod deleted the fix/nk-bdd-create-wallet branch December 19, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bug and continue our create wallet feature.

2 participants