Skip to content

Comments

feat(web): add wallet filter modal#645

Merged
pierrelstan merged 2 commits intoGreenstand:mainfrom
fengyunfengyun1:feat/wallet-filters-dialog
Dec 20, 2025
Merged

feat(web): add wallet filter modal#645
pierrelstan merged 2 commits intoGreenstand:mainfrom
fengyunfengyun1:feat/wallet-filters-dialog

Conversation

@fengyunfengyun1
Copy link
Contributor

Description

Create a Wallet Filter component for the Wallet Details screen.

Fixes: #345
or
Resolves: # (issue number)


Changes Made

  • Changes in apps folder (specify the app and briefly describe the
    changes):

    • Web
    • Native
  • Changes in packages folder (specify the package and briefly describe
    the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Before After
"screenshot before"
Screenshot 2025-12-14 at 11 52 37 PM |

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

(Optional) Add any additional comments or notes for reviewers here.

@pierrelstan pierrelstan self-requested a review December 15, 2025 23:29
pierrelstan

This comment was marked as off-topic.

@pierrelstan pierrelstan self-requested a review December 15, 2025 23:42
Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @fengyunfengyun1

@pierrelstan
Copy link
Collaborator

@fengyunfengyun1 Please resolve the merge conflicts in the Header component so we can merge this PR.

@pierrelstan pierrelstan merged commit c8a9640 into Greenstand:main Dec 20, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallet filter Modal

2 participants