Skip to content

Comments

feat(native): add settings screen header component#698

Open
v1gneshn wants to merge 1 commit intoGreenstand:mainfrom
v1gneshn:settingheader
Open

feat(native): add settings screen header component#698
v1gneshn wants to merge 1 commit intoGreenstand:mainfrom
v1gneshn:settingheader

Conversation

@v1gneshn
Copy link

  • Create reusable ScreenHeader component with centered title design
  • Integrate header into settings screen to match Figma UI design
  • Remove commented-out header code and redundant title text
  • Add proper accessibility labels and theme-based styling
  • Support optional back button and right action slots for reusability

Fixes #697

Description

Please provide a clear and concise description of the changes made, including
the purpose and context.

Fixes: # (issue number)
or
Resolves: # (issue number)


Changes Made

  • Changes in apps folder (specify the app and briefly describe the
    changes):

    • Web
    • Native
  • Changes in packages folder (specify the package and briefly describe
    the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Before After
"screenshot before" "screenshot after"

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

(Optional) Add any additional comments or notes for reviewers here.

- Create reusable ScreenHeader component with centered title design
- Integrate header into settings screen to match Figma UI design
- Remove commented-out header code and redundant title text
- Add proper accessibility labels and theme-based styling
- Support optional back button and right action slots for reusability

Fixes Greenstand#697

Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header works well here, but since the settings screen is planned to include multiple sub‑screens (account, notifications, etc.), consider updating the _layout.tsx file inside the settings folder. This would allow you to define the header via Stack.Screen options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add settings screen header to match UI design

2 participants