-
Notifications
You must be signed in to change notification settings - Fork 52
More spawns, fixes and preserve history #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
54a2c7c
Added lumbridge guard attackable version
M1krofin cabe48c
Added giant rat spawn close to lumbridge castle
M1krofin 3129ecc
deleted master farmer spawn (was added later in rs3 in lumbridge)
M1krofin 4884f98
Fixed tool leprechaun and fayeth spawn closer to tree patch
M1krofin 961815e
Fixed ram npc death animation
M1krofin 929b704
Fixed giant rat and rat death animations
M1krofin bcfc101
Added clan cup plaque to preserve history
M1krofin bb50159
Fixed black wool and ball of black wool not tradeable
M1krofin 2784829
Added two statistic signposts
M1krofin 5910b8e
Spotless
M1krofin e11769d
Fixes
M1krofin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| [clan_cup_interface] | ||
| id = 205 | ||
|
|
||
| [.combined_winners_button] | ||
| id = 49 | ||
|
|
||
| [.skilling_winners_button] | ||
| id = 53 | ||
|
|
||
| [.combat_winners_button] | ||
| id = 57 | ||
|
|
||
| [.current_winners_button] | ||
| id = 61 | ||
|
|
||
| [.sub_text] | ||
| id = 64 | ||
|
|
||
| [.main_text] | ||
| id = 65 | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| [ram_death] | ||
| id = 5336 | ||
| ticks = 2 | ||
|
|
||
| [ram_defend] | ||
| id = 5337 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
game/src/main/kotlin/content/area/misthalin/ClanCupPlaque.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package content.area.misthalin | ||
|
|
||
| import world.gregs.voidps.engine.Script | ||
| import world.gregs.voidps.engine.client.ui.open | ||
|
|
||
| class ClanCupPlaque : Script { | ||
| init { | ||
| // https://www.youtube.com/watch?v=K-Ptq7ZxeWI | ||
| objectOperate("Read", "lumbridge_clan_cup_plaque") { | ||
| open("clan_cup_interface") | ||
| interfaces.sendText("clan_cup_interface", "current_winners_button", "Current") | ||
| interfaces.sendText("clan_cup_interface", "main_text", "Current Winners") | ||
| interfaces.sendText("clan_cup_interface", "sub_text", "The victorious winners of the 2010 Jagex Clan Cup<br><br>Combat - Runescape Dinasty<br>Skilling - Divination<br>Combined - BasedIn2Minutes") | ||
| } | ||
| interfaceOption("Current-winners", "clan_cup_interface:current_winners_button") { | ||
| interfaces.sendText("clan_cup_interface", "current_winners", "Current") | ||
| interfaces.sendText("clan_cup_interface", "main_text", "Current Winners") | ||
| interfaces.sendText("clan_cup_interface", "sub_text", "The victorious winners of the 2010 Jagex Clan Cup<br><br>Combat - Runescape Dinasty<br>Skilling - Divination<br>Combined - Basedin2minutes") | ||
| } | ||
| interfaceOption("Combat-winners", "clan_cup_interface:combat_winners_button") { | ||
| interfaces.sendText("clan_cup_interface", "combat_winners", "Combat") | ||
| interfaces.sendText("clan_cup_interface", "main_text", "Combat winners") | ||
| interfaces.sendText("clan_cup_interface", "sub_text", "2010 - Runescape Dinasty<br>2009 - The Titans") | ||
| } | ||
| interfaceOption("Skilling-winners", "clan_cup_interface:skilling_winners_button") { | ||
| interfaces.sendText("clan_cup_interface", "skilling_winners", "Skilling") | ||
| interfaces.sendText("clan_cup_interface", "main_text", "Skilling Winners") | ||
| interfaces.sendText("clan_cup_interface", "sub_text", "2010 - Divination<br> 2009 - Divination") | ||
| } | ||
| interfaceOption("Combined-winners", "clan_cup_interface:combined_winners_button") { | ||
| interfaces.sendText("clan_cup_interface", "combined_winners", "Combined") | ||
| interfaces.sendText("clan_cup_interface", "main_text", "Combined Winners") | ||
| interfaces.sendText("clan_cup_interface", "sub_text", "2010 - BasedIn2Minutes<br> 2009 - Wicked Fury") | ||
| } | ||
| } | ||
| } | ||
22 changes: 22 additions & 0 deletions
22
game/src/main/kotlin/content/area/misthalin/lumbridge/CowFieldSignpost.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package content.area.misthalin.lumbridge | ||
|
|
||
| import content.entity.player.dialogue.type.statement | ||
| import world.gregs.voidps.engine.Script | ||
|
|
||
| class CowFieldSignpost : Script { | ||
|
|
||
| var cowDeathsToday: Int = 0 | ||
|
|
||
| init { | ||
| npcDeath("cow*") { | ||
| cowDeathsToday += 1 | ||
| } | ||
| objectOperate("Read", "lumbridge_signpost_cow") { | ||
| if (cowDeathsToday > 0) { | ||
| statement("Local cowherders have reported that $cowDeathsToday cows have been slain in this field today by passing adventurers. Farmers throughout the land fear this may be an epidemic.") | ||
| } else { | ||
| statement("The Lumbridge cow population has been thriving today, without a single cow death to worry about!") | ||
| } | ||
| } | ||
| } | ||
| } | ||
22 changes: 22 additions & 0 deletions
22
game/src/main/kotlin/content/area/misthalin/lumbridge/PlayerDeathSignpost.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package content.area.misthalin.lumbridge | ||
|
|
||
| import content.entity.player.dialogue.type.statement | ||
| import world.gregs.voidps.engine.Script | ||
| import world.gregs.voidps.engine.data.Settings | ||
|
|
||
| class PlayerDeathSignpost : Script { | ||
| var playerDeathsToday: Int = 0 | ||
|
|
||
| init { | ||
| playerDeath { | ||
| playerDeathsToday += 1 | ||
| } | ||
| objectOperate("Read", "lumbridge_signpost_death") { | ||
| if (playerDeathsToday > 0) { | ||
| statement("So far today, $playerDeathsToday unlucky adventurers have died on ${Settings["server.name"]} and been sent to their respawn location. Be careful out there.") | ||
| } else { | ||
| statement("So far today, not a single adventurer on ${Settings["server.name"]} has met their end grisly or otherwise. Either the streets are getting safer or adventurers are getting warier.") | ||
| } | ||
| } | ||
| } | ||
| } | ||
9 changes: 8 additions & 1 deletion
9
game/src/main/kotlin/content/area/misthalin/lumbridge/castle/LumbridgeGuardsman.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
game/src/main/kotlin/content/entity/npc/combat/melee/LumbridgeGuardsmanAttackble.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package content.entity.npc.combat.melee | ||
|
|
||
| import content.entity.combat.killer | ||
| import world.gregs.voidps.engine.Script | ||
| import world.gregs.voidps.engine.client.instruction.handle.interactNpc | ||
| import world.gregs.voidps.engine.entity.character.npc.NPC | ||
| import world.gregs.voidps.engine.entity.character.player.skill.Skill | ||
| import world.gregs.voidps.engine.queue.strongQueue | ||
|
|
||
| class LumbridgeGuardsmanAttackble : Script { | ||
| init { | ||
| huntNPC("aggressive_npcs") { target -> | ||
| if (id == "lumbridge_guardsman_attackable2" && target.id.endsWith("rat")) { | ||
| interactNpc(target, "Attack") | ||
| } | ||
| if (id == "lumbridge_guardsman_attackable" && target.id.contains("goblin")) { | ||
| interactNpc(target, "Attack") | ||
| } | ||
| } | ||
| npcDeath("goblin*,giant_rat") { | ||
| val guard = killer as? NPC ?: return@npcDeath | ||
| when { | ||
| // Guard attacked rats and giant rats, but only healed when giant rat was killed https://youtu.be/qC_XoAQK6Cs?si=VH9tOmKXu-_Bgjnr&t=137 | ||
| id == ("giant_rat") && guard.id == "lumbridge_guardsman_attackable2" -> { | ||
| guard.strongQueue("rat_killer") { | ||
| guard.delay(2) | ||
| guard.anim("eat_drink") | ||
| // From wiki: Every time they kill a monster, they eat a piece of food which heals them to full health, and walk over to the square of their death as to collect a drop. | ||
| guard.levels.set(Skill.Constitution, guard.levels.getMax(Skill.Constitution)) | ||
| guard.walkTo(tile) | ||
| } | ||
| } | ||
| id.contains("goblin") && guard.id == "lumbridge_guardsman_attackable" -> { | ||
| guard.strongQueue("goblin_killer") { | ||
| guard.delay(2) | ||
| guard.anim("eat_drink") | ||
| guard.levels.set(Skill.Constitution, guard.levels.getMax(Skill.Constitution)) | ||
| guard.walkTo(tile) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth considering if these values should be saved (if so how) as they'll reset anytime the server restarts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add source to this but in runescape they reset after 24h, I don't know if in void there is 24h reset. But this is actually a good suggestion if we save them, because you can see then how many times players have died or killed cows in whole server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://runescape.fandom.com/wiki/Signpost
"The information signs show various statistics when read. They reset when the server is rebooted."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay yeah there's no 24h reset (it could be added) but if it's just per server reboot then this is good enough for me