Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Dec 15, 2025

Closes #749

  • Farming growth cycle
  • Most farming patches
  • Harvesting, diseases, curing, death
  • Plant pots, saplings, fruit bags
  • Gardeners, protections and tool leprechauns
  • Composting
  • Commands

Tweaks:

  • Remove unused options text files
  • Improved interface debugging
  • Allow modifying system time in tests
  • Allow access to script classes in tests
  • Tidy up log output
  • Add "vars" search command

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Qodana Community for JVM

13 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 13

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 50.08026% with 622 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.33%. Comparing base (00f624c) to head (4daff22).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...me/src/main/kotlin/content/skill/farming/Farmer.kt 4.50% 106 Missing ⚠️
...rc/main/kotlin/content/skill/farming/CompostBin.kt 42.14% 53 Missing and 28 partials ⚠️
...e/src/main/kotlin/content/skill/farming/Farming.kt 68.49% 19 Missing and 27 partials ⚠️
...in/kotlin/content/skill/farming/FarmingCommands.kt 13.20% 46 Missing ⚠️
...otlin/content/skill/farming/FarmingPatchInspect.kt 32.81% 36 Missing and 7 partials ⚠️
...ain/kotlin/content/skill/farming/ToolLeprechaun.kt 6.81% 41 Missing ⚠️
.../kotlin/content/skill/farming/FarmingPatchTreat.kt 58.10% 19 Missing and 12 partials ⚠️
...n/kotlin/content/skill/farming/FarmingPatchPick.kt 66.27% 13 Missing and 16 partials ⚠️
.../kotlin/content/skill/farming/FarmingPatchPlant.kt 56.89% 14 Missing and 11 partials ⚠️
game/src/main/kotlin/content/skill/farming/Sack.kt 62.50% 8 Missing and 16 partials ⚠️
... and 25 more
Additional details and impacted files
Files with missing lines Coverage Δ
.../main/kotlin/world/gregs/voidps/engine/GameLoop.kt 3.12% <ø> (ø)
.../world/gregs/voidps/engine/client/ui/Interfaces.kt 61.42% <100.00%> (-0.28%) ⬇️
...tlin/world/gregs/voidps/engine/timer/TimerQueue.kt 78.43% <100.00%> (+1.83%) ⬆️
...otlin/world/gregs/voidps/engine/timer/TimerSlot.kt 85.29% <100.00%> (+1.42%) ⬆️
...n/kotlin/world/gregs/voidps/engine/timer/Timers.kt 18.18% <ø> (ø)
game/src/main/kotlin/GameModules.kt 56.36% <100.00%> (+0.80%) ⬆️
game/src/main/kotlin/content/entity/Examines.kt 56.75% <100.00%> (+2.47%) ⬆️
.../src/main/kotlin/content/entity/obj/BushPicking.kt 44.44% <100.00%> (ø)
...in/content/entity/player/command/PlayerCommands.kt 29.78% <100.00%> (+1.13%) ⬆️
.../content/entity/player/command/TeleportCommands.kt 62.33% <100.00%> (+2.06%) ⬆️
... and 44 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #814      +/-   ##
============================================
+ Coverage     37.07%   37.33%   +0.26%     
- Complexity     7087     7243     +156     
============================================
  Files          1462     1479      +17     
  Lines         56289    57429    +1140     
  Branches      14099    14403     +304     
============================================
+ Hits          20869    21443     +574     
- Misses        30779    31205     +426     
- Partials       4641     4781     +140     
Components Coverage Δ
Content 34.44% <51.50%> (+0.52%) ⬆️
Engine 44.74% <17.30%> (-0.06%) ⬇️
Network 60.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit ea7f7e6 into main Dec 16, 2025
5 checks passed
@GregHib GregHib deleted the farming branch December 16, 2025 01:33
Ilwyd pushed a commit to Ilwyd/void that referenced this pull request Dec 22, 2025
* Replace Timer events for dispatchers

* Rename Key to Timer

* Make sure return types are explicit

* Add farming objects

* Start adding farming growth cycle

* Update farming tick

* Farming produce wip

* Add remaining estimate to Timers

* Add customizable timer tick rate

* Fix

* Add farming vars

* Add dispatcher support for using interface or items on entities

* WIP

* Rebase

* Start adding compost bins

* Adding more compost bin functionality

* Rename returnedItems variable to avoid auto suggests for `return`

* Fix farming tick tests

* Add compost bins

* WIP farming patches

* Watering and harvesting

* Formatting

* Add data for all allotment patches

* Add herb data

* Add flower, hops and tree data

* Tool equipment storage WIP

* Tool equipment storage WIP

* Tidy up log outputs

* Add farming store tests

* Use gardening trowel instead of trowel

* Add plant pot filling

* Split out plant pots and add sapling replacing

* Add patch clearing

* Fix seed id

* Add scroll of life

* Fix varbits

* Add plant cure messages

* Align varbit names

* Add plant cure lunar spell

* Add plant cure dead message

* Add tests for allotment and herb patches

* FileStorage changes for compiler type issue

* Add flower patch tests

* Add hops patch tests

* Start adding fruit trees

* Lil bit of data

* Add fruit tree harvesting

* Delete unused option files

* Change patch lives from decrementing to incrementing

* Add bush patches

* Add fruit tree claiming xp

* Check farming growth tick immediately on login

* Add most of tree patches

* Add fruit tree fruit regrowing

* Add all farmers

* Add tree pruning

* Fix magic crossbow et al. damage calculation

* Fix chinchompa explode gfx

* Fix dark bow special attack

* Fix coloured dragon attack distance

* Fix locust sounds

* Start cactus patch

* Add farming rake success rates

* Add cactus patch

* Add belladonna patch

* Add evil turnip patch

* Add spirit tree patches

* Add all farming object examines

* Add flower patch protections

* Refactor FarmingPatch

* Add tree root harvesting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Farming

2 participants