Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Jan 3, 2026

Official naming:

  • Afraid -> Scared
  • Chuckle -> Laugh
  • RollEyes -> Bored
  • Surprised -> Shock
  • Talk -> Neutral
  • Uncertain -> Confused
  • Upset -> Sad

Unofficial names changed to avoid conflicts:

  • Laugh -> Cackle
  • Sad -> Disheartened
  • Scared -> Terrified
  • Shock -> Horrified
  • Neutral -> Idle

Also removed rarely used option filter.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 6.91044% with 3004 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.63%. Comparing base (c446b2e) to head (41a9c53).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ontent/area/misthalin/barbarian_village/Dororan.kt 0.00% 260 Missing ⚠️
...otlin/content/area/kharidian_desert/RugMerchant.kt 5.30% 124 Missing and 1 partial ⚠️
...content/area/misthalin/barbarian_village/Gudrun.kt 0.00% 82 Missing ⚠️
.../content/area/misthalin/lumbridge/FredTheFarmer.kt 0.00% 74 Missing ⚠️
.../kotlin/content/area/asgarnia/taverley/Kaqemeex.kt 0.00% 73 Missing ⚠️
...ent/quest/free/the_restless_ghost/RestlessGhost.kt 0.00% 69 Missing ⚠️
...n/content/area/misthalin/wizards_tower/Traiborn.kt 0.00% 65 Missing ⚠️
...content/area/misthalin/varrock/palace/SirPrysin.kt 0.00% 62 Missing ⚠️
...nt/area/kharidian_desert/sophanem/GuardianMummy.kt 0.00% 55 Missing ⚠️
...kotlin/content/area/misthalin/varrock/GypsyAris.kt 0.00% 52 Missing ⚠️
... and 175 more
Additional details and impacted files
Files with missing lines Coverage Δ
...t/area/kandarin/tree_gnome_stronghold/Blurberry.kt 47.36% <100.00%> (ø)
...main/kotlin/content/area/karamja/BartenderZambo.kt 40.00% <100.00%> (ø)
.../area/kharidian_desert/shantay_pass/ShantayPass.kt 22.58% <100.00%> (ø)
...onghold_of_security/StrongholdOfSecurityRewards.kt 38.27% <100.00%> (ø)
...tlin/content/entity/player/dialogue/type/Choice.kt 93.10% <100.00%> (ø)
...lin/content/activity/shooting_star/ShootingStar.kt 12.03% <0.00%> (ø)
...ain/kotlin/content/area/asgarnia/falador/Iconis.kt 18.18% <0.00%> (ø)
.../kotlin/content/area/kandarin/ardougne/Ardougne.kt 43.07% <0.00%> (ø)
...tronghold_of_security/StrongholdOfSecurityDoors.kt 24.65% <0.00%> (ø)
...ontent/area/misthalin/draynor_village/PrinceAli.kt 61.76% <66.66%> (ø)
... and 180 more

... and 2 files with indirect coverage changes

@@            Coverage Diff            @@
##               main     #821   +/-   ##
=========================================
  Coverage     37.63%   37.63%           
+ Complexity     7387     7384    -3     
=========================================
  Files          1486     1486           
  Lines         58453    58440   -13     
  Branches      14589    14597    +8     
=========================================
- Hits          21998    21995    -3     
+ Misses        31591    31577   -14     
- Partials       4864     4868    +4     
Components Coverage Δ
Content 34.82% <6.91%> (+<0.01%) ⬆️
Engine 44.59% <ø> (ø)
Network 60.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit db4f6bb into main Jan 3, 2026
5 checks passed
@GregHib GregHib deleted the dialogue branch January 3, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants