Skip to content

Fix a bunch of bugs #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 12 commits into from
Feb 21, 2026

Fix incorrect formula tests

36433ef
Select commit
Loading
Failed to load commit list.
Merged

Fix a bunch of bugs #897

Fix incorrect formula tests
36433ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2026 in 1s

37.89% (-0.01%) compared to 4c70694

View this Pull Request on Codecov

37.89% (-0.01%) compared to 4c70694

Details

Codecov Report

❌ Patch coverage is 35.57692% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.89%. Comparing base (4c70694) to head (36433ef).

Files with missing lines Patch % Lines
...ain/kotlin/content/skill/farming/ToolLeprechaun.kt 0.00% 17 Missing ⚠️
...n/content/entity/player/modal/tab/QuestJournals.kt 20.00% 12 Missing ⚠️
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 41.17% 6 Missing and 4 partials ⚠️
...in/kotlin/content/area/misthalin/lumbridge/Hank.kt 25.00% 6 Missing ⚠️
...rc/main/kotlin/world/gregs/voidps/type/Distance.kt 0.00% 5 Missing ⚠️
...in/content/entity/player/command/ServerCommands.kt 0.00% 4 Missing ⚠️
.../gregs/voidps/engine/entity/character/Character.kt 0.00% 3 Missing ⚠️
...ntity/character/mode/move/target/TargetStrategy.kt 87.50% 2 Missing ⚠️
...world/gregs/voidps/engine/entity/obj/GameObject.kt 0.00% 2 Missing ⚠️
...kotlin/content/entity/player/equip/EquipBonuses.kt 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
Files with missing lines Coverage Δ
...idps/engine/entity/character/mode/move/Movement.kt 59.02% <100.00%> (+0.28%) ⬆️
game/src/main/kotlin/content/skill/melee/Weapon.kt 87.50% <100.00%> (ø)
.../main/kotlin/content/entity/obj/ObjectTeleports.kt 75.00% <0.00%> (ø)
...es/src/main/kotlin/world/gregs/voidps/type/Tile.kt 43.47% <0.00%> (ø)
...ntity/character/mode/move/target/TargetStrategy.kt 61.29% <87.50%> (-3.00%) ⬇️
...world/gregs/voidps/engine/entity/obj/GameObject.kt 65.62% <0.00%> (ø)
...kotlin/content/entity/player/equip/EquipBonuses.kt 63.33% <0.00%> (+3.95%) ⬆️
...in/content/entity/player/equip/EquipmentBonuses.kt 23.89% <80.00%> (+0.47%) ⬆️
.../gregs/voidps/engine/entity/character/Character.kt 8.64% <0.00%> (ø)
...in/content/entity/player/command/ServerCommands.kt 16.66% <0.00%> (-0.58%) ⬇️
... and 5 more 
@@             Coverage Diff              @@
##               main     #897      +/-   ##
============================================
- Coverage     37.90%   37.89%   -0.01%     
- Complexity     7529     7531       +2     
============================================
  Files          1556     1557       +1     
  Lines         60682    60726      +44     
  Branches      15351    15362      +11     
============================================
+ Hits          23002    23015      +13     
- Misses        32529    32559      +30     
- Partials       5151     5152       +1
Components Coverage Δ
Content 35.67% <28.00%> (-0.01%) ⬇️
Engine 42.77% <69.56%> (+<0.01%) ⬆️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov