Skip to content

Replace enum and struct definitions with object & fix flakey GE test #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregHib merged 7 commits into from
Feb 25, 2026

Fix tests

eba84e4
Select commit
Loading
Failed to load commit list.
Merged

Replace enum and struct definitions with object & fix flakey GE test #898

Fix tests
eba84e4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 25, 2026 in 1s

37.88% (-0.03%) compared to 4c70694

View this Pull Request on Codecov

37.88% (-0.03%) compared to 4c70694

Details

Codecov Report

❌ Patch coverage is 28.28947% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.88%. Comparing base (4c70694) to head (eba84e4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/voidps/engine/data/definition/EnumDefinitions.kt 0.00% 14 Missing ⚠️
...n/content/entity/player/modal/CharacterCreation.kt 7.14% 13 Missing ⚠️
...voidps/engine/data/definition/StructDefinitions.kt 0.00% 11 Missing ⚠️
game/src/main/kotlin/content/bot/BotCommands.kt 0.00% 7 Missing ⚠️
...tity/character/player/equip/AppearanceOverrides.kt 16.66% 5 Missing ⚠️
...otlin/content/area/asgarnia/falador/Hairdresser.kt 16.66% 5 Missing ⚠️
...tlin/content/area/asgarnia/falador/MakeoverMage.kt 16.66% 5 Missing ⚠️
...c/main/kotlin/content/skill/summoning/Summoning.kt 20.00% 4 Missing ⚠️
...e/src/main/kotlin/content/social/chat/QuickChat.kt 0.00% 4 Missing ⚠️
...n/content/area/fremennik_province/rellekka/Yrsa.kt 25.00% 3 Missing ⚠️
... and 24 more
Additional details and impacted files
Files with missing lines Coverage Δ
game/src/main/kotlin/GameModules.kt 51.28% <100.00%> (ø)
...isthalin/varrock/grand_exchange/CommonItemCosts.kt 87.50% <100.00%> (-0.74%) ⬇️
...rc/main/kotlin/content/entity/death/PlayerDeath.kt 53.60% <100.00%> (ø)
...tlin/content/entity/player/command/ItemCommands.kt 50.76% <ø> (-0.75%) ⬇️
.../content/entity/player/command/TeleportCommands.kt 61.33% <ø> (-0.51%) ⬇️
...lin/content/entity/player/kept/ItemsKeptOnDeath.kt 68.75% <100.00%> (ø)
...lin/content/social/trade/exchange/GrandExchange.kt 67.33% <100.00%> (ø)
...t/social/trade/exchange/history/ExchangeHistory.kt 46.15% <100.00%> (ø)
...n/content/social/trade/exchange/limit/BuyLimits.kt 88.23% <100.00%> (ø)
.../kotlin/world/gregs/voidps/engine/EngineModules.kt 0.00% <0.00%> (ø)
... and 33 more

... and 12 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #898      +/-   ##
============================================
- Coverage     37.90%   37.88%   -0.03%     
- Complexity     7529     7547      +18     
============================================
  Files          1556     1557       +1     
  Lines         60682    60718      +36     
  Branches      15351    15361      +10     
============================================
+ Hits          23002    23003       +1     
- Misses        32529    32565      +36     
+ Partials       5151     5150       -1
Components Coverage Δ
Content 35.66% <37.16%> (-0.03%) ⬇️
Engine 42.73% <2.56%> (-0.04%) ⬇️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov