Skip to content

Fix: Per-item eat/attack delays, chinchompa splash gating#958

Merged
GregHib merged 24 commits intoGregHib:mainfrom
HarleyGilpin:bugs/april-bug-fixes
Apr 22, 2026
Merged

Fix: Per-item eat/attack delays, chinchompa splash gating#958
GregHib merged 24 commits intoGregHib:mainfrom
HarleyGilpin:bugs/april-bug-fixes

Conversation

@HarleyGilpin
Copy link
Copy Markdown
Contributor

fix: per-item eat/attack delays, chinchompa splash gating

Summary of changes

  • Food and drink items now support per-item eat_delay and attack_delay params (new Params.EAT_DELAY / Params.ATTACK_DELAY). Eating.kt reads them with sensible fallbacks
    (1/2/3 ticks for combo/drink/food, 0 for drink attack delay, 3 for food).
  • Eating mid-combat extends action_delay by the item's attack_delay instead of being a no-op — shark/karambwan combo stacks correctly, brews do not push back the attack timer.
  • Tagged combo foods (cooked octopus aka karambwan, crunchies, batta, chocolate bomb, tangled toads' legs, worm hole, veg ball) with combo = true, attack_delay = 2, eat_delay = 3.
    Cakes/slices/pies get eat_delay matching RS (1–3 ticks).
  • Chinchompa AoE splash only triggers when the main target takes damage > 0 - no more free splash on a miss. This also fixes a game crash caused by damage splash resulting in negative integers.

Testing

  • New EatingTest covering: mid-attack eat extension, shark→karambwan combo stacking, out-of-combat pizza (no action_delay), half-pizza eat_delay, brew drink (no action_delay
    extension), combo food bypassing food_delay.

Linked Issues: #953

HarleyGilpin and others added 23 commits April 10, 2026 18:43
…rAll.kt

Co-authored-by: Greg <GregHib@users.noreply.github.com>
…rAll.kt

Co-authored-by: Greg <GregHib@users.noreply.github.com>
…walkable one, so a single blocked direction no longer traps the NPC.
@HarleyGilpin HarleyGilpin changed the title fix: per-item eat/attack delays, chinchompa splash gating Fix: Per-item eat/attack delays, chinchompa splash gating Apr 22, 2026
Copy link
Copy Markdown
Contributor Author

@HarleyGilpin HarleyGilpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code passes unit testing, please see game/src/test/kotlin/content/skill/constitution/EatingTest.kt

@GregHib GregHib merged commit 53994b3 into GregHib:main Apr 22, 2026
2 checks passed
@GregHib
Copy link
Copy Markdown
Owner

GregHib commented Apr 22, 2026

For future reference can you use rebase to update so we can avoid duplicating commit messages i.e. 53994b3

Thanks :)

@HarleyGilpin
Copy link
Copy Markdown
Contributor Author

For future reference can you use rebase to update so we can avoid duplicating commit messages i.e. 53994b3

Thanks :)

Whoops my bad, I'll keep an eye out next time.

@HarleyGilpin HarleyGilpin deleted the bugs/april-bug-fixes branch April 23, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants