Fix: Per-item eat/attack delays, chinchompa splash gating#958
Merged
GregHib merged 24 commits intoGregHib:mainfrom Apr 22, 2026
Merged
Fix: Per-item eat/attack delays, chinchompa splash gating#958GregHib merged 24 commits intoGregHib:mainfrom
GregHib merged 24 commits intoGregHib:mainfrom
Conversation
…rAll.kt Co-authored-by: Greg <GregHib@users.noreply.github.com>
…rAll.kt Co-authored-by: Greg <GregHib@users.noreply.github.com>
…walkable one, so a single blocked direction no longer traps the NPC.
HarleyGilpin
commented
Apr 22, 2026
GregHib
approved these changes
Apr 22, 2026
Owner
|
For future reference can you use rebase to update so we can avoid duplicating commit messages i.e. 53994b3 Thanks :) |
Contributor
Author
Whoops my bad, I'll keep an eye out next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: per-item eat/attack delays, chinchompa splash gating
Summary of changes
eat_delayandattack_delayparams (newParams.EAT_DELAY/Params.ATTACK_DELAY).Eating.ktreads them with sensible fallbacks(1/2/3 ticks for combo/drink/food, 0 for drink attack delay, 3 for food).
action_delayby the item'sattack_delayinstead of being a no-op — shark/karambwan combo stacks correctly, brews do not push back the attack timer.combo = true,attack_delay = 2,eat_delay = 3.Cakes/slices/pies get
eat_delaymatching RS (1–3 ticks).damage > 0- no more free splash on a miss. This also fixes a game crash caused by damage splash resulting in negative integers.Testing
EatingTestcovering: mid-attack eat extension, shark→karambwan combo stacking, out-of-combat pizza (no action_delay), half-pizzaeat_delay, brew drink (no action_delayextension), combo food bypassing
food_delay.Linked Issues: #953