Skip to content

Fix spell auto-casting and freezing movement#959

Merged
GregHib merged 9 commits intomainfrom
autocast
Apr 22, 2026
Merged

Fix spell auto-casting and freezing movement#959
GregHib merged 9 commits intomainfrom
autocast

Conversation

@GregHib
Copy link
Copy Markdown
Owner

@GregHib GregHib commented Apr 22, 2026

  • Fix missing spell items clearing autocast instead of spells Autocast breaking on ancients #954
  • Fix missing spell on player interaction (probably missed when splitting onCharacter interactions ages ago)
  • Fix splashing self with AoE

GregHib and others added 3 commits April 22, 2026 16:38
- Add source parameter to multiTargets() to filter out attacker
- Prevents ice barrage/burst from hitting self in multi when adjacent to target
- Updates spell handler to pass caster reference
@GregHib GregHib mentioned this pull request Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 46.34146% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.18%. Comparing base (53994b3) to head (e4ff745).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...idps/engine/entity/character/mode/move/Movement.kt 22.22% 11 Missing and 3 partials ⚠️
...main/kotlin/content/entity/player/combat/Attack.kt 80.00% 0 Missing and 2 partials ⚠️
...ain/kotlin/content/entity/effect/EffectCommands.kt 0.00% 1 Missing ⚠️
...me/src/main/kotlin/content/entity/effect/Freeze.kt 87.50% 1 Missing ⚠️
...main/kotlin/content/skill/magic/book/SpellRunes.kt 0.00% 1 Missing ⚠️
...rc/main/kotlin/content/skill/magic/spell/Spells.kt 0.00% 1 Missing ⚠️
...n/content/skill/melee/weapon/SpecialAttackMelee.kt 0.00% 1 Missing ⚠️
...n/kotlin/content/skill/ranged/weapon/Chinchompa.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../engine/entity/character/mode/interact/Interact.kt 54.45% <ø> (-0.45%) ⬇️
...ain/kotlin/content/entity/effect/EffectCommands.kt 28.20% <0.00%> (ø)
...me/src/main/kotlin/content/entity/effect/Freeze.kt 51.11% <87.50%> (ø)
...main/kotlin/content/skill/magic/book/SpellRunes.kt 66.66% <0.00%> (ø)
...rc/main/kotlin/content/skill/magic/spell/Spells.kt 68.42% <0.00%> (ø)
...n/content/skill/melee/weapon/SpecialAttackMelee.kt 0.00% <0.00%> (ø)
...n/kotlin/content/skill/ranged/weapon/Chinchompa.kt 50.00% <0.00%> (ø)
...main/kotlin/content/entity/player/combat/Attack.kt 50.57% <80.00%> (+3.82%) ⬆️
...idps/engine/entity/character/mode/move/Movement.kt 56.47% <22.22%> (+0.18%) ⬆️

... and 1 file with indirect coverage changes

@@            Coverage Diff            @@
##               main     #959   +/-   ##
=========================================
  Coverage     38.17%   38.18%           
+ Complexity     8127     8126    -1     
=========================================
  Files          1678     1678           
  Lines         76303    76315   +12     
  Branches      16800    16802    +2     
=========================================
+ Hits          29132    29144   +12     
  Misses        41494    41494           
  Partials       5677     5677           
Components Coverage Δ
Content 36.00% <65.21%> (+0.01%) ⬆️
Engine 46.71% <22.22%> (+<0.01%) ⬆️
Network 60.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib changed the title Fix spell auto-casting Fix spell auto-casting and freezing movement Apr 22, 2026
@GregHib GregHib merged commit 9cece50 into main Apr 22, 2026
5 checks passed
@GregHib GregHib deleted the autocast branch April 22, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants