Fixes multiblock rendering issues on world load#4302
Merged
jurrejelle merged 1 commit intoGregTechCEu:re/1.21-with-lovefrom Dec 11, 2025
Merged
Fixes multiblock rendering issues on world load#4302jurrejelle merged 1 commit intoGregTechCEu:re/1.21-with-lovefrom
jurrejelle merged 1 commit intoGregTechCEu:re/1.21-with-lovefrom
Conversation
Fixes GregTechCEu#4276 Addresses an issue where multiblocks sometimes fail to render correctly after initial chunk loading due to the block entity not being fully initialized when the chunk is first rendered. Forces a model data refresh on the client side when a block entity finishes loading to ensure correct rendering of multiblocks, especially in cases where the chunk was rendered before the block entity was fully available. Also, it avoids returning null model render types, which could cause the block to be invisible, by instead returning the render types of the default model.
jurrejelle
added
ignore changelog
jurrejelle
approved these changes
Dec 11, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
LGTM, thanks and congratz on first contribution :D
jurrejelle
merged commit afa0c28
into
GregTechCEu:re/1.21-with-love
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addresses an issue where multiblocks sometimes fail to render correctly after initial chunk loading due to the block entity not being fully initialized when the chunk is first rendered.
Implementation Details
Forces a model data refresh on the client side when a block entity finishes loading to ensure correct rendering of multiblocks, especially in cases where the chunk was rendered before the block entity was fully available. Also, it avoids returning null model render types, which could cause the block to be invisible, by instead returning the render types of the default model.
Outcome
Fixes #4276