KubeJS Duration Check #4327
Merged
KubeJS Duration Check #4327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoungOnionMC
added
type: bugfix
Spicierspace153
approved these changes
Dec 15, 2025
LeoDreamer2004
pushed a commit
to LeoDreamer2004/GregTech-Modern
that referenced
this pull request
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Skips the recipe from registering if the duration is non positive, led to a crash in overclocking logic
also added several constants to GTValues for various amounts of time in ticks(seconds, minutes, hours etc)
Implementation Details
non positive check and log and return
Outcome
no more bug