-
Notifications
You must be signed in to change notification settings - Fork 204
Add Material Working Tier #2429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
woah. |
src/main/java/gregtech/loaders/recipe/handlers/PartsRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/loaders/recipe/handlers/PartsRecipeHandler.java
Outdated
Show resolved
Hide resolved
|
As to answer your questions: I do agree with TechLord22 that ULV should be supported as a tier, for no other reason than that there isn't a reason not to give developers a way to autogen recipes under 8 EU/t. |
c39431f to
d78fdf6
Compare
- Enable ULV working tier - Apply to gem crystallization
Zorbatron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
processGemConversionprocessFrame
are missing scaling. Is this intentional?
Pipe and dust packing isn't scaled which I'm going to assume is intentional (would be wack imo)
src/main/java/gregtech/loaders/recipe/handlers/MaterialRecipeHandler.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/gregtech/loaders/recipe/handlers/ToolRecipeHandler.java
|
On the latest commit, I added scaling for framboxes and gem uptiering. I am not 100% about the frame boxes though, I could go either way on it. I also don't believe we need the two other places where you pointed out that scaling may be needed. |
src/main/java/gregtech/loaders/recipe/handlers/MaterialRecipeHandler.java
Outdated
Show resolved
Hide resolved
Add in HV checks for mortar grinding
Adds a "working tier" field to all materials, which specifies the minimum voltage that any given working recipe (extruding, bending, solidifying, fluid extracting, wiremilling, etc.) should be. Currently this is just an API, as no materials specify anything above default. The field is publicly accessible and settable for existing materials by addons, groovyscript and crafttweaker, as well as for new materials in a material builder call.
Rather than blindly setting the voltage for carefully chosen EU/t recipes (like the bender being 24 EU/t) to the VA[tier] value, it attempts to scale the voltage to the appropriate adjusted amount at the provided tier. Examples:
Additionally, any material with a working tier above HV will no longer generate manual recipes for parts, such as using a Hammer to craft 2 ingots into plates or a File to craft an ingot into a rod.
Open questions on whether these should receive working tier scaling:
As an additional larger question: should this feature include polarizing to remove our special cases for Neodymium (HV polarizer) and Samarium (IV polarizer)? Or should these continue to be special cases so that they do not need to also gain higher voltage working recipes apart from polarizing?