Fix Catalysts in Dichlorobenzidine and Diaminobenzidine #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechLord22
previously requested changes
Nov 24, 2024
src/main/java/gregtech/loaders/recipe/chemistry/PolymerRecipes.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
added
the
type: refactor
serenibyss
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the catalysts of 3,3-Dichlorobenzidine and 3,3-Diaminobenzidine being swapped, relative to the actual synthesis process.
See Nomi-CEu/Nomi-CEu#935.
Implementation Details
This PR removes the specialised LCR recipe for Dichlorobenzidine, and makes it require a whole dust of zinc, set to non-consumable. I assumed this would be preferable behaviour, given they are catalysts, but I can reverse this change if necessary.Edit:
Since consuming copper is intended, the recipe for Diaminobenzidine has been moved to the chemical reactor, with tiny pile of copper, and a seperate recipe in the large chemical reactor has been created, with copper dust. The duration, inputs and outputs have been multiplied 9x, but not the EUt, just as before.
Outcome
Fixes Nomi-CEu/Nomi-CEu#935.
Chemists are slightly happier.
The usage of zinc/copper in Dichlorobenzidine is actually one of a catalyst.Additional Information
None
Potential Compatibility Issues
Patterns and/or processing lines will break. Should be a simple swap in PBI setups.