Open
Conversation
buffer V2.0
ALongStringOfNumbers
added
the
type: refactor
Contributor
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
I feel like 2k, 4k, and 8k are too low for the buffer sizes. Maybe we could scale to the old max and have 16, 32, 64. Or a small nerf and have 8, 16, 32.
The Fluid slots do not display the maximum amount when they are empty, or the click to fill tooltip, but this may just be an issue with our MUI fluid slot implementation.
| super.setFrontFacing(frontFacing); | ||
| if (this.outputFacingItems == null || this.outputFacingFluids == null) { | ||
| setOutputFacing(frontFacing.getOpposite()); | ||
| } |
Contributor
There was a problem hiding this comment.
Why change the output facing when the front facing is changed? I do not believe any other of our machines do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
I've implemented auto-output for buffers. Moreover I fixed the gui (fluid slots were 1 pixel offset), and nerfed the tanksize (lv buffers have 3 x 4 buckets, mv ones have 4 x 8 buckets and hv ones have 5 x 16 buckets). 64 buckets in all tiers is too much imo (if you don't share this opinion, lemme know and I'll revert the changes).