-
Notifications
You must be signed in to change notification settings - Fork 204
Added property for specially registered tools #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ALongStringOfNumbers
merged 15 commits into
GregTechCEu:master
from
littlecube8152:littlecube-soft-tool-fix
Feb 14, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
26c0c89
Added repairing recipe workaround for specially registered tools
littlecube8152 e908995
add ExtraToolProperty
littlecube8152 b180442
Fixed overriding issue
littlecube8152 05e56fc
Integrated soft tools using the new ExtraToolProperty
littlecube8152 9127765
Obtain markerItem of mallets and plungers from its own get method
littlecube8152 2cfcfdb
Spotless formatting
littlecube8152 c38866d
Change soft tool property registration to already existing method (en…
littlecube8152 09df4b3
Remove accidentally left debugging output
littlecube8152 d61efe3
Fix many properties are not properly overridden
littlecube8152 7169eb8
Add GroovyScript integration
littlecube8152 f1237eb
Fix misleading variable name (toolClass -> toolId)
littlecube8152 5e98391
Merge branch 'master' into littlecube-soft-tool-fix
littlecube8152 b7c6027
Merge branch 'master' into littlecube-soft-tool-fix
littlecube8152 f6ddb77
refactor ToolProperty -> MaterialToolProperty and SimpleToolProperty …
littlecube8152 c22f817
Use actual map methods
littlecube8152 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for the explicit casting and separating the
*=apart? The+=and*=operators implicitly perform the casting for integer types, iirc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but the operands are floating point numbers, so I just wanted to be clear here.