Fix the cleanroom multiblock overriding the cleanroom provider set by cleaning hatches. #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider in RecipeMapMultiblockControllers if the priority is higher than the existing one.
Don't check for an existing cleanroom in the cleaning hatch.
ALongStringOfNumbers
added
type: bug
ALongStringOfNumbers
approved these changes
Jan 28, 2025
...ech/common/metatileentities/multi/multiblockpart/MetaTileEntityCleaningMaintenanceHatch.java
Outdated
Show resolved
Hide resolved
…o remove after testing)
ALongStringOfNumbers
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In my addon, I have a maintenance hatch that is like the cleaning maintenance hatch but it does sterile cleaning. The cleanroom set by the hatch gets overriden by a cleanroom multiblock if the multi is built inside one.
Implementation Details
An
ICleanroomProvidercan specify a priority which and inRecipeMapMultiblockControllers, the internal cleanroom provider will only be set if the new one has a higher priority than the existing one. This priority defaults to0. Cleaning hatches override than and return max int, so it won't be replaced by a cleanroom multiblocks provider (which doesn't overridegetPriority.Additional Information
Zorbatron/ZBGT#133