switch to XoShiRo256++ random #2747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-W-K
reviewed
Mar 1, 2025
M-W-K
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Switches from
XSTRtoXoShiRo256++as the random generator implementation used by GT.In testing,
256++was found to be effectively equal or better in terms of speed, and most likely also has better randomness.Implementation Details
SplitMix64is used to generate the 256 bits of state for256++, it should not be used for actual random number generation.XoRoShiRo128+is used to generate random seeds for other PRNG implementations when created without an initial seed. It is not exposed elsewhere, and should not be used for any other purpose.