2 Small Changes #2754
Open
2 Small Changes #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went by the following rules: 1) If an element has at least 2 stable isotopes, use the one with the highest isotopic signature 2) If an element has only 1 stable isotope, use that 3) If an element has no stable isotopes, use the one with the longest half life time
…ingle item reference to mole reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I've noticed that some elements are not using their most abundant/most stable isotope as their base one. Details on what was changed exactly can be found in the description of the commit.
Imo it's kinda bothering/misleading that the average mass/protons/neutrons in the material tree are shown with respect to a single dust/ingot instead of per mole. Of course this applies to compounds only but look at PBI for example: A compound with 36 total components showing 8 as its average mass is nonsense xD
Outcome
Corrected all elements and changed the material tree to work with moles instead. See screenshot below. If you really dislike the material tree change, I'll be sad but can revert that commit, so no need to prematurely close this.
