Remove old ASM implementations #2756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
added
the
type: refactor
TechLord22
reviewed
Apr 27, 2025
TechLord22
approved these changes
Apr 27, 2025
TechLord22
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the old ASM implementations, now that we are transitioned to mixins.
Keeps a couple of the old
xxHooksclasses around, since they had a decent amount of logic in them for specific things.Implementation Details
Not sure about the transformer exclusion on the mixins package. We get dinged by it a couple times in the logs, and I am not sure if it is even needed any more, since switching to mixins.
Outcome
Remove old ASM implementations.