Skip to content

Conversation

@brachy84
Copy link
Contributor

@brachy84 brachy84 commented Mar 21, 2025

What

Cleanroom does not detect open or closed doors currently. This fixes it.

Implementation Details

Based on the state properties it's first checked on which axis the door would be considered closed (even when the property may say open). Then we just check the 4 neighboring blocks on that axis. That check checking if the material is solid like (not a fluid, does not break from piston, etc) and checking if the bounding box touches the door. This works for most blocks with simple shapes. However blocks like gt pipes always pass the checks

Outcome

Cleanroom structure invalidates if the open door check fails.

Additional Information

Idk if this is something we actually want and in what form. Further discussion is needed on this.

Potential Compatibility Issues

Current clearoom woth open doors invalidate :trollface:

@brachy84 brachy84 added status: open for discussion Issue or PR is open for discussion type: bug Something isn't working type: feature New feature or request status: do not merge PR should not be merged labels Mar 21, 2025
@brachy84 brachy84 requested a review from a team as a code owner March 21, 2025 21:14
@brachy84 brachy84 removed the status: do not merge PR should not be merged label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: open for discussion Issue or PR is open for discussion type: bug Something isn't working type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants