Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cleanroom does not detect open or closed doors currently. This fixes it.
Implementation Details
Based on the state properties it's first checked on which axis the door would be considered closed (even when the property may say open). Then we just check the 4 neighboring blocks on that axis. That check checking if the material is solid like (not a fluid, does not break from piston, etc) and checking if the bounding box touches the door. This works for most blocks with simple shapes. However blocks like gt pipes always pass the checks
Outcome
Cleanroom structure invalidates if the open door check fails.
Additional Information
Idk if this is something we actually want and in what form. Further discussion is needed on this.
Potential Compatibility Issues
Current clearoom woth open doors invalidate