Make grs setFormula method behave in the same way as ceu ones#2772
Merged
ALongStringOfNumbers merged 3 commits intoGregTechCEu:masterfrom Apr 27, 2025
Merged
Make grs setFormula method behave in the same way as ceu ones#2772ALongStringOfNumbers merged 3 commits intoGregTechCEu:masterfrom
ALongStringOfNumbers merged 3 commits intoGregTechCEu:masterfrom
Conversation
brachy84
approved these changes
Apr 21, 2025
Contributor
brachy84
left a comment
There was a problem hiding this comment.
Im wondering why these exist at all when they just delegate to gt
bruberu
reviewed
Apr 21, 2025
Member
bruberu
left a comment
There was a problem hiding this comment.
Since there is probably plenty of time before this would actually go in-game, there are a couple other methods that could be added to this PR, such as setIconSet, setHarvestLevel, setBurnTime, addToolEnchantment, addScaledToolEnchantment, setToolStats (all), setOverrideToolStats, and setBlastTemp.
Member
|
OK, I've done precisely that. |
ALongStringOfNumbers
approved these changes
Apr 27, 2025
ALongStringOfNumbers
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the
setFormulamethod expansion from grs behave in the same way as ceu's. (i.e. returns the material instance instead of void return.Implementation Details
Simply changes method returns to the material instead of nothing.
Outcome
In be4 this kind of code works in java but not in a grs script (since it considers groovy mixin'd methods first):
instead one needs to use:
This PR makes the former form of code possible via grs.
Potential Compatibility Issues
None that I could think of?