Skip to content

Conversation

@MCTian-mi
Copy link
Contributor

What

Check the title. Only register BlockMachines / pipe blocks for MTERegistries / MaterialRegistries that has registered entries for them.

Implementation Details

Adding some if blocks, just like that.

Outcome

Fixes CleanroomMC/BetterQuesting#75

Additional Information

Nope.

Potential Compatibility Issues

Forge might warn ppl about missing entries when they enter existing saves but that's all righty ig.

@MCTian-mi MCTian-mi requested a review from a team as a code owner May 3, 2025 03:21
@ALongStringOfNumbers ALongStringOfNumbers added the type: bug Something isn't working label May 3, 2025
@screret
Copy link

screret commented May 5, 2025

Oh. That's my issue. From 2022.
Oh no.

@MCTian-mi
Copy link
Contributor Author

MCTian-mi commented May 6, 2025

oh I just found out this crashes groovyscript object mappers
hold on

nvm that's yet another bug

@ALongStringOfNumbers ALongStringOfNumbers merged commit b24ff3e into GregTechCEu:master May 11, 2025
3 of 4 checks passed
@MCTian-mi MCTian-mi deleted the pipe-registration-fix branch May 11, 2025 00:22
MCTian-mi added a commit to MCTian-mi/SussyPatches that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when trying to add items to task

3 participants