Fix saving/loading of the machine owner UUID to NBT #2783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the saving and loading of the stored player UUID to track a machine's owner.
The problem was that when setting the UUID it used
setUniqueId("key", uuid)which sets "(key)Most" and "(key)Least" to store the two longs that make up the UUID, but when checking if the NBT tag had a stored UUID, it only checked if it had a tag with the key "key", which it never would.Implementation Details
Saves the owner to a compound tag "Owner" and check/get that instead.
Outcome
Machines don't lose their owner on world reloads.
Potential Compatibility Issues
N/A