Skip to content

Conversation

@MCTian-mi
Copy link
Contributor

What

Fixes:

  • Hand commands not adding namespaces for materials/metaitems/metaprefix items/pipes/frames/material blocks registered by addons
Type Before After
MetaPrefixItems image image
MetaItems image image
Pipes image image
Frames image image
MaterialBlocks image image
Recipe Removal Strings image image

Implementation Details

Adding check for nameSpaces for these items.

Outcome

Commands mentioned above now works fine.

Potential Compatibility Issues

None that I am aware of.

@MCTian-mi MCTian-mi requested a review from a team as a code owner May 11, 2025 03:37
@Zorbatron Zorbatron added the type: refactor Suggestion to refactor a section of code label May 11, 2025
@brachy84
Copy link
Contributor

Did you test this with grs master? Since waiting did some fixes on our side.

@MCTian-mi
Copy link
Contributor Author

Did you test this with grs master? Since waiting did some fixes on our side.

no I tested it with grs 1.2.3, but yeah waiting told me to check infoparser in grs (I'll check that later)

@TechLord22 TechLord22 merged commit 9b2950f into GregTechCEu:master May 20, 2025
3 checks passed
@MCTian-mi MCTian-mi deleted the various-grs-fixes branch June 13, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants