Rework Neighbor Cache to use Weak References #2828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactors the neighbor cache to use a list of weak references instead of an array with direct references
Implementation Details
add
NULLandINVALIDweak references to mimic previous logic.if
INVALID, the neighbor should be recomputed, otherwise either the TE ornullshould be returnedIt also needs to be checked that the neighbors are not null unexpectedly due to referent being lost somehow
Outcome
Theoretically, references to neighboring TEs should be GC'd properly now.