Skip to content

Fix ClassNotFound exceptions on servers due to client only class being accessed in cover code #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zorbatron merged 1 commit into from
Aug 7, 2025
Merged

Fix ClassNotFound exceptions on servers due to client only class being accessed in cover code #2829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/gregtech/common/covers/ender/CoverAbstractEnderLink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ protected IWidget createIoRow() {
.coverChildrenHeight()
.child(new ToggleButton()
.value(new BooleanSyncValue(this::isIoEnabled, this::setIoEnabled))
.overlay(IKey.dynamic(() -> IKey.lang(this.ioEnabled ?
.overlay(IKey.lang(() -> this.ioEnabled ?
"behaviour.soft_hammer.enabled" :
"behaviour.soft_hammer.disabled").get())
"behaviour.soft_hammer.disabled")
.color(Color.WHITE.darker(1)))
.widthRel(0.6f)
.left(0));
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/gregtech/common/covers/filter/BaseFilterContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public boolean isItemValid(int slot, @NotNull ItemStack stack) {

protected abstract boolean isItemValid(ItemStack stack);

protected abstract String getFilterName();
protected abstract @NotNull IKey getFilterKey();

@Override
public @NotNull ItemStack insertItem(int slot, @NotNull ItemStack stack, boolean simulate) {
Expand Down Expand Up @@ -244,7 +244,7 @@ public IWidget initUI(GuiData data, PanelSyncManager manager) {
}
return true;
}))
.child(IKey.dynamic(this::getFilterName)
.child(getFilterKey()
.color(CoverWithUI.UI_TEXT_COLOR)
.shadow(false)
.alignment(Alignment.CenterRight).asWidget()
Expand Down
9 changes: 5 additions & 4 deletions src/main/java/gregtech/common/covers/filter/FluidFilterContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import com.cleanroommc.modularui.api.drawable.IKey;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;

import java.util.function.BooleanSupplier;
import java.util.function.Consumer;
Expand Down Expand Up @@ -56,9 +57,9 @@ protected boolean isItemValid(ItemStack stack) {
}

@Override
protected String getFilterName() {
return hasFilter() ?
getFilterStack().getDisplayName() :
IKey.lang("metaitem.fluid_filter.name").get();
protected @NotNull IKey getFilterKey() {
return IKey.lang(() -> hasFilter() ?
getFilterStack().getTranslationKey() + ".name" :
"metaitem.fluid_filter.name");
}
}
9 changes: 5 additions & 4 deletions src/main/java/gregtech/common/covers/filter/ItemFilterContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import com.cleanroommc.modularui.api.drawable.IKey;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;

import java.util.function.BooleanSupplier;
import java.util.function.Consumer;
Expand Down Expand Up @@ -57,9 +58,9 @@ protected boolean isItemValid(ItemStack stack) {
}

@Override
protected String getFilterName() {
return hasFilter() ?
getFilterStack().getDisplayName() :
IKey.lang("metaitem.item_filter.name").get();
protected @NotNull IKey getFilterKey() {
return IKey.lang(() -> hasFilter() ?
getFilterStack().getTranslationKey() + ".name" :
"metaitem.item_filter.name");
}
}
Loading