Fix Alfheim lighting engine ram usage workaround with Alfheim 1.6 #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
approved these changes
Jun 30, 2025
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes JEI not loading when Alfheim version 1.6 is loaded due to our method of forcing its lighting engine to not be used in our dummy worlds.
Implementation Details
Alfheim 1.6 changes the lighting engine to be lazy-loaded (using a Lombok annotation for some reason), which causes an NPE if we simply set the lighting engine to
null. This PR overrides the Lombok-generated getter to always return null, avoiding the issue, and keeps the old method of simply setting it to null around to keep compat with Alfheim <= 1.5.Outcome
JEI works when recent versions of Alfheim are installed.
Fixes #2775, supersedes #2837 and #2833
Potential Compatibility Issues
None, hopefully