Skip to content

Conversation

@MCTian-mi
Copy link
Contributor

What

OptFine will try to scale up item/block icons whose size is not a multiple of 16, in this case, GT logos are 17x, and got scaled up to 80x, which caused it to look really blurred.

This PR fixes this in a brute-force approach: scale these two icons 16 times larger (17 pix -> 272 pix)

Before:
d0a438dc11c2eeb9d468f8c7a518fe45
After:
8bb7eb319721afb6a04f7813a80cc831

@MCTian-mi MCTian-mi requested a review from a team as a code owner August 6, 2025 03:43
@Tictim
Copy link
Contributor

Tictim commented Aug 6, 2025

When I added the logo item I contemplated whether to make the texture 17x or 32x, I chose 17x at the end because I didn't think there were any consequences apart from forge printing two warning statements. Oh well.

Using 32x texture and setting XY scale of the logo model json to 2 might be a better approach. Probably needs to fiddle a bit around offsets. (Spawning the logo item in your inventory makes it easier to see the offset fyi)

@MCTian-mi
Copy link
Contributor Author

When I added the logo item I contemplated whether to make the texture 17x or 32x, I chose 17x at the end because I didn't think there were any consequences apart from forge printing two warning statements. Oh well.

Using 32x texture and setting XY scale of the logo model json to 2 might be a better approach. Probably needs to fiddle a bit around offsets. (Spawning the logo item in your inventory makes it easier to see the offset fyi)

Done

@Zorbatron Zorbatron added the type: bug Something isn't working label Aug 7, 2025
@Zorbatron Zorbatron merged commit abb98d7 into GregTechCEu:master Aug 7, 2025
3 of 4 checks passed
@MCTian-mi MCTian-mi changed the title Fix optifine blurring GT creative tab icons by scaling logos by 16x Fix optifine blurring GT creative tab icons by scaling logos to 32x Aug 23, 2025
@MCTian-mi MCTian-mi deleted the creative-tab-icon branch August 23, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants