Allow giving mtes custom soundtypes #2853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
MeowmelMuku
added a commit
to GTQT/GregTech
that referenced
this pull request
Aug 21, 2025
- 实现量子箱的物品耐久条渲染 - 添加背包模块的混入类（使林业背包支持粗矿） - 合并PR：GregTechCEu#2853 - 合并PR：GregTechCEu#2853
Contributor
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
Could you also apply this PR to our Variant Blocks, for consistency?
IE, Coke Oven Bricks get the same sound type as the coke oven MTE
MCTian-mi
force-pushed
the
custom-sound
branch
from
b5cf494 to
225ce76
Compare
Contributor
Author
|
Ok I give up on assigning custom sounds to material blocks for now If I would like to do that it would be in another pr, ig |
ALongStringOfNumbers
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Redirects
Block#getSoundType(IBlockState, World, BlockPos, Entity)to base MTE class, allowing to give mte non-metal sound types.Also this gives wooden/stone sound types to existing mtes in gregtech.