Fix regression in #2672 which made all GT material fluids unsearchable in JEI #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
Aug 22, 2025
Zorbatron
added a commit
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#2672 changed
GTFluid.GTMaterialFluid#getLocalizedName()to callgetLocalizedKey().get(). This works as it should during normal gameplay, but will always returnnullwhile minecraft is loading due toLangKeyline 51this.time == ClientScreenHandler.getTicks(). Thetimefield starts at0but while MC is loading,ClientScreenHandler.getTicks()will also be0causing it to always return the uninitializedstringcache. JEI creates its ingredient filter during loading, so it ends up having an empty string as the display name for all GT material fluids.Implementation Details
Simply sets the default
timefield inLangKeyto-1instead of0, so it will properly translate the key while MC is loading. It will be set to 0 after the first translation is done, so the behavior is the same as before.Outcome
You can search for fluids in JEI again! 😃
Potential Compatibility Issues
Shouldn't be any.
Related MUI2 PR: CleanroomMC/ModularUI#159