Merged
Conversation
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
github-actions
bot
added
documentation
There was a problem hiding this comment.
Pull request overview
This pull request implements streaming and bulk write functionality for the GreptimeDB .NET ingester SDK. The changes add two high-throughput data ingestion methods: streaming write via gRPC for concurrent writes from multiple threads with backpressure handling, and bulk write via Apache Arrow Flight for maximum throughput using columnar data transfer.
Changes:
- Added streaming write capability with
StreamIngestWriterusing gRPC bidirectional streaming - Added bulk write capability with
BulkWriterusing Apache Arrow Flight protocol - Implemented Arrow integration infrastructure including
RecordBatchBuilderandArrowTypeMapper - Fixed bug in
TypeCoercion.csfor proper DateTime handling - Added comprehensive unit and integration tests
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 24 comments.
Show a summary per file
| File | Description |
|---|---|
| RecordBatchBuilderTests.cs | Comprehensive unit tests for Arrow RecordBatch building |
| ArrowTypeMapperTests.cs | Unit tests for type mapping between GreptimeDB and Arrow types |
| StreamIngestWriterIntegrationTests.cs | Integration tests for streaming writer with various scenarios |
| BulkWriterIntegrationTests.cs | Integration tests for bulk writer including setup patterns |
| TypeCoercion.cs | Fixed DateTime type coercion to use correct timestamp unit |
| TableBuilder.cs | Added GetColumnDefinitions helper method for schema inspection |
| StreamIngestWriterOptions.cs | Configuration options with validation |
| StreamIngestWriter.cs | Thread-safe streaming writer with channel-based backpressure |
| IStreamIngestWriter.cs | Interface defining streaming writer contract |
| IBulkWriter.cs | Interface defining bulk writer contract |
| GreptimeClient.cs | Added factory methods for streaming and bulk writers |
| BulkWriter.cs | Arrow Flight-based bulk writer implementation |
| RecordBatchBuilder.cs | Converts GreptimeDB tables to Arrow RecordBatch format |
| ArrowTypeMapper.cs | Maps GreptimeDB types to Apache Arrow types |
| README.md | Updated documentation with streaming and bulk write examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/GreptimeDB.Ingester.IntegrationTests/StreamIngestWriterIntegrationTests.cs
Outdated
Show resolved
Hide resolved
tests/GreptimeDB.Ingester.IntegrationTests/BulkWriterIntegrationTests.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.