fix(bulk-write): ensure table exists before bulk write #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zqr10159
commented
Jul 14, 2025
zqr10159
commented
- Add logic to ensure the target table exists before starting bulk write
- Update README with important notes about bulk write API usage
- Refactor write loops in benchmark classes for better readability
- Add logic to ensure the target table exists before starting bulk write - Update README with important notes about bulk write API usage - Refactor write loops in benchmark classes for better readability
- Add logic to ensure the target table exists before starting bulk write - Update README with important notes about bulk write API usage - Refactor write loops in benchmark classes for better readability
- Add logic to ensure the target table exists before starting bulk write - Update README with important notes about bulk write API usage - Refactor write loops in benchmark classes for better readability
fengjiachun
reviewed
Jul 15, 2025
ingester-example/src/main/java/io/greptime/bench/benchmark/BulkWriteBenchmark.java
Outdated
Show resolved
Hide resolved
Contributor
|
Others LGTM, thanks @zqr10159 |
fengjiachun
approved these changes
Jul 15, 2025
- Add a check to ensure there are rows available in the table data provider - Remove the conditional statement and directly call `rows.next()` to add the initial row - Improve error handling by throwing an `IllegalStateException` if no rows are available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.